| Message ID | 1469494766-26601-2-git-send-email-sjg@chromium.org |
|---|---|
| State | Accepted |
| Commit | fda4fa8195bab36879272e92973a7ef39e759795 |
| Delegated to: | Bin Meng |
| Headers | show |
Hello Simon, Am 26.07.2016 um 02:58 schrieb Simon Glass: > Add a debug() at this point to help figure out what is wrong. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > arch/x86/cpu/intel_common/cpu.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Heiko Schocher<hs@denx.de> but wondering why this is in the "binman: A tool for creating firmware images" series. bye, Heiko > > diff --git a/arch/x86/cpu/intel_common/cpu.c b/arch/x86/cpu/intel_common/cpu.c > index 0fdef6f..ae42095 100644 > --- a/arch/x86/cpu/intel_common/cpu.c > +++ b/arch/x86/cpu/intel_common/cpu.c > @@ -42,8 +42,10 @@ int cpu_common_init(void) > enable_lapic(); > > ret = microcode_update_intel(); > - if (ret && ret != -EEXIST) > + if (ret && ret != -EEXIST) { > + debug("%s: Microcode update failure (err=%d)\n", __func__, ret); > return ret; > + } > > /* Enable upper 128bytes of CMOS */ > writel(1 << 2, RCB_REG(RC)); >
On Tue, Jul 26, 2016 at 8:58 AM, Simon Glass <sjg@chromium.org> wrote: > Add a debug() at this point to help figure out what is wrong. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > arch/x86/cpu/intel_common/cpu.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On Thu, Jul 28, 2016 at 2:53 PM, Bin Meng <bmeng.cn@gmail.com> wrote: > On Tue, Jul 26, 2016 at 8:58 AM, Simon Glass <sjg@chromium.org> wrote: >> Add a debug() at this point to help figure out what is wrong. >> >> Signed-off-by: Simon Glass <sjg@chromium.org> >> --- >> >> arch/x86/cpu/intel_common/cpu.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> applied to u-boot-x86, thanks!
diff --git a/arch/x86/cpu/intel_common/cpu.c b/arch/x86/cpu/intel_common/cpu.c index 0fdef6f..ae42095 100644 --- a/arch/x86/cpu/intel_common/cpu.c +++ b/arch/x86/cpu/intel_common/cpu.c @@ -42,8 +42,10 @@ int cpu_common_init(void) enable_lapic(); ret = microcode_update_intel(); - if (ret && ret != -EEXIST) + if (ret && ret != -EEXIST) { + debug("%s: Microcode update failure (err=%d)\n", __func__, ret); return ret; + } /* Enable upper 128bytes of CMOS */ writel(1 << 2, RCB_REG(RC));
Add a debug() at this point to help figure out what is wrong. Signed-off-by: Simon Glass <sjg@chromium.org> --- arch/x86/cpu/intel_common/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)