diff mbox

[v2] directfb: depends on NPTL threading

Message ID 20160708222129.GA22796@waldemar-brodkorb.de
State Accepted
Headers show

Commit Message

Waldemar Brodkorb July 8, 2016, 10:21 p.m. UTC
Fixes following autobuild failure:
http://autobuild.buildroot.net/results/162db0d62075a16c7abae1229676e2cdb29fe953/

Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
v1 -> v2:
  - rather adding an experimental patch without runtime testing for
    an unmaintained software, we depend on NPTL as discussed with
    Thomas Petazzoni on IRC
---
 package/directfb/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Romain Naour July 16, 2016, 3:36 p.m. UTC | #1
Hi Waldemar,

Le 09/07/2016 à 00:21, Waldemar Brodkorb a écrit :
> Fixes following autobuild failure:
> http://autobuild.buildroot.net/results/162db0d62075a16c7abae1229676e2cdb29fe953/

Please propagate BR2_TOOLCHAIN_HAS_THREADS_NPTL to the comment dependency at the
bottom of the file.

With that fixed:
  Reviewed-by: Romain Naour <romain.naour@gmail.com>

Best regards,
Romain

> 
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
> v1 -> v2:
>   - rather adding an experimental patch without runtime testing for
>     an unmaintained software, we depend on NPTL as discussed with
>     Thomas Petazzoni on IRC
> ---
>  package/directfb/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/directfb/Config.in b/package/directfb/Config.in
> index f0bcaaa..f38f051 100644
> --- a/package/directfb/Config.in
> +++ b/package/directfb/Config.in
> @@ -1,6 +1,6 @@
>  config BR2_PACKAGE_DIRECTFB
>  	bool "directfb"
> -	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
>  	depends on BR2_INSTALL_LIBSTDCPP
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_5
>  	depends on !BR2_TOOLCHAIN_USES_MUSL # sigval_t issue
>
Thomas Petazzoni July 17, 2016, 1:08 p.m. UTC | #2
Hello,

On Sat, 9 Jul 2016 00:21:29 +0200, Waldemar Brodkorb wrote:
> Fixes following autobuild failure:
> http://autobuild.buildroot.net/results/162db0d62075a16c7abae1229676e2cdb29fe953/
> 
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
> v1 -> v2:
>   - rather adding an experimental patch without runtime testing for
>     an unmaintained software, we depend on NPTL as discussed with
>     Thomas Petazzoni on IRC
> ---
>  package/directfb/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I've applied, after adjusting the Config.in comment, as noticed by
Romain Naour.

Thanks!

Thomas
diff mbox

Patch

diff --git a/package/directfb/Config.in b/package/directfb/Config.in
index f0bcaaa..f38f051 100644
--- a/package/directfb/Config.in
+++ b/package/directfb/Config.in
@@ -1,6 +1,6 @@ 
 config BR2_PACKAGE_DIRECTFB
 	bool "directfb"
-	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_5
 	depends on !BR2_TOOLCHAIN_USES_MUSL # sigval_t issue