| Message ID | 1467910890-16574-1-git-send-email-francois.perrad@gadz.org |
|---|---|
| State | Rejected |
| Headers | show |
Hello, On Thu, 7 Jul 2016 19:01:30 +0200, Francois Perrad wrote: > tekui doesn't really require these Lua modules. > These modules are added because they increase the user experience with demo/examples. > > Signed-off-by: Francois Perrad <francois.perrad@gadz.org> Then perhaps there should be a sub-option to enable the demo/examples? Thanks, Thomas
2016-07-07 21:32 GMT+02:00 Thomas Petazzoni <thomas.petazzoni@free-electrons.com>: > Hello, > > On Thu, 7 Jul 2016 19:01:30 +0200, Francois Perrad wrote: >> tekui doesn't really require these Lua modules. >> These modules are added because they increase the user experience with demo/examples. >> >> Signed-off-by: Francois Perrad <francois.perrad@gadz.org> > > Then perhaps there should be a sub-option to enable the demo/examples? > A sub-option "Demo" is usual in BR. But with TekUI, the sub-option will be "Dependencies for Demo". It sounds bad. François > Thanks, > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Hello, On Fri, 8 Jul 2016 09:42:00 +0200, François Perrad wrote: > A sub-option "Demo" is usual in BR. > But with TekUI, the sub-option will be "Dependencies for Demo". > It sounds bad. Why would the sub-option be named "Dependencies for Demo" ? If the tekui build system automatically detects the availability of those dependencies to build/install the demos, then it is just fine: you can have a sub-option called "Install demos" that adds the necessary dependencies. Or is tekui installing the demos unconditionally, and then they are potentially broken on the target due to missing dependencies ? Thomas
Forget this patch. TekUI requires dynamic library. François 2016-07-07 19:01 GMT+02:00 Francois Perrad <fperrad@gmail.com>: > tekui doesn't really require these Lua modules. > These modules are added because they increase the user experience with > demo/examples. > > Signed-off-by: Francois Perrad <francois.perrad@gadz.org> > --- > package/tekui/Config.in | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/package/tekui/Config.in b/package/tekui/Config.in > index 1203667..5f461ec 100644 > --- a/package/tekui/Config.in > +++ b/package/tekui/Config.in > @@ -1,11 +1,10 @@ > config BR2_PACKAGE_TEKUI > bool "tekui" > select BR2_PACKAGE_FREETYPE > - select BR2_PACKAGE_LUAFILESYSTEM # runtime only > - select BR2_PACKAGE_LUAEXPAT # runtime only > - select BR2_PACKAGE_LUASOCKET # runtime only > - select BR2_PACKAGE_LUAPOSIX # runtime only > - depends on !BR2_STATIC_LIBS > + select BR2_PACKAGE_LUAFILESYSTEM if !BR2_STATIC_LIBS # runtime > only (demo/examples) > + select BR2_PACKAGE_LUAEXPAT if !BR2_STATIC_LIBS # runtime > only (demo/examples) > + select BR2_PACKAGE_LUASOCKET if !BR2_STATIC_LIBS # > runtime only (demo/examples) > + select BR2_PACKAGE_LUAPOSIX if !BR2_STATIC_LIBS # runtime > only (demo/examples) > depends on BR2_PACKAGE_HAS_LUAINTERPRETER > depends on BR2_TOOLCHAIN_HAS_THREADS > help > @@ -16,6 +15,5 @@ config BR2_PACKAGE_TEKUI > > http://tekui.neoscientists.org/ > > -comment "tekui needs a Lua interpreter and a toolchain w/ threads, > dynamic library" > - depends on !BR2_PACKAGE_HAS_LUAINTERPRETER || > !BR2_TOOLCHAIN_HAS_THREADS || \ > - BR2_STATIC_LIBS > +comment "tekui needs a Lua interpreter and a toolchain w/ threads" > + depends on !BR2_PACKAGE_HAS_LUAINTERPRETER || > !BR2_TOOLCHAIN_HAS_THREADS > -- > 2.7.4 > >
diff --git a/package/tekui/Config.in b/package/tekui/Config.in index 1203667..5f461ec 100644 --- a/package/tekui/Config.in +++ b/package/tekui/Config.in @@ -1,11 +1,10 @@ config BR2_PACKAGE_TEKUI bool "tekui" select BR2_PACKAGE_FREETYPE - select BR2_PACKAGE_LUAFILESYSTEM # runtime only - select BR2_PACKAGE_LUAEXPAT # runtime only - select BR2_PACKAGE_LUASOCKET # runtime only - select BR2_PACKAGE_LUAPOSIX # runtime only - depends on !BR2_STATIC_LIBS + select BR2_PACKAGE_LUAFILESYSTEM if !BR2_STATIC_LIBS # runtime only (demo/examples) + select BR2_PACKAGE_LUAEXPAT if !BR2_STATIC_LIBS # runtime only (demo/examples) + select BR2_PACKAGE_LUASOCKET if !BR2_STATIC_LIBS # runtime only (demo/examples) + select BR2_PACKAGE_LUAPOSIX if !BR2_STATIC_LIBS # runtime only (demo/examples) depends on BR2_PACKAGE_HAS_LUAINTERPRETER depends on BR2_TOOLCHAIN_HAS_THREADS help @@ -16,6 +15,5 @@ config BR2_PACKAGE_TEKUI http://tekui.neoscientists.org/ -comment "tekui needs a Lua interpreter and a toolchain w/ threads, dynamic library" - depends on !BR2_PACKAGE_HAS_LUAINTERPRETER || !BR2_TOOLCHAIN_HAS_THREADS || \ - BR2_STATIC_LIBS +comment "tekui needs a Lua interpreter and a toolchain w/ threads" + depends on !BR2_PACKAGE_HAS_LUAINTERPRETER || !BR2_TOOLCHAIN_HAS_THREADS
tekui doesn't really require these Lua modules. These modules are added because they increase the user experience with demo/examples. Signed-off-by: Francois Perrad <francois.perrad@gadz.org> --- package/tekui/Config.in | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-)