| Message ID | 1467740148-10178-1-git-send-email-yann.morin.1998@free.fr |
|---|---|
| State | Accepted |
| Headers | show |
Hi Yann, Le 05/07/2016 à 19:35, Yann E. MORIN a écrit : > jemalloc has a hard-coded list of supported architectures, which it uses > to define the minimum alignment for allocations. It whines at build time > (not at configure time) when it does not know that alignment. > > Fix that by making jemalloc depend on the known-supported architectures. > > Fixes: > http://autobuild.buildroot.org/results/674/674b6022f9a403528a758c0785656d2bda79e0a9/ Reviewed-by: Romain Naour <romain.naour@gmail.com> Best regards, Romain > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr> > --- > package/jemalloc/Config.in | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/package/jemalloc/Config.in b/package/jemalloc/Config.in > index ff74387..a166821 100644 > --- a/package/jemalloc/Config.in > +++ b/package/jemalloc/Config.in > @@ -1,5 +1,15 @@ > +config BR2_PACKAGE_JEMALLOC_ARCH_SUPPORTS > + bool > + default y if BR2_arm || BR2_armeb || BR2_aarch64 || BR2_aarch64_be > + default y if BR2_i386 || BR2_x86_64 > + default y if BR2_mips || BR2_mipsel > + default y if BR2_sparc64 > + default y if BR2_powerpc > + default y if BR2_sh && !BR2_sh2a > + > config BR2_PACKAGE_JEMALLOC > bool "jemalloc" > + depends on BR2_PACKAGE_JEMALLOC_ARCH_SUPPORTS > depends on !BR2_STATIC_LIBS > help > This library providing a malloc(3) implementation that emphasizes > @@ -8,4 +18,5 @@ config BR2_PACKAGE_JEMALLOC > http://www.canonware.com/jemalloc/ > > comment "jemalloc needs a toolchain w/ dynamic library" > + depends on BR2_PACKAGE_JEMALLOC_ARCH_SUPPORTS > depends on BR2_STATIC_LIBS >
Hello, On Tue, 5 Jul 2016 19:35:48 +0200, Yann E. MORIN wrote: > jemalloc has a hard-coded list of supported architectures, which it uses > to define the minimum alignment for allocations. It whines at build time > (not at configure time) when it does not know that alignment. > > Fix that by making jemalloc depend on the known-supported architectures. > > Fixes: > http://autobuild.buildroot.org/results/674/674b6022f9a403528a758c0785656d2bda79e0a9/ > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr> > --- > package/jemalloc/Config.in | 11 +++++++++++ > 1 file changed, 11 insertions(+) Thanks, applied with a few minor modifications: [Thomas: - split ARM and AArch64 dependencies on two lines - for SuperH, instead of using BR2_sh && !BR2_sh2, explicitly list the SH4 variants, since only SH4 is supported by jemalloc.] Thanks! Thomas
diff --git a/package/jemalloc/Config.in b/package/jemalloc/Config.in index ff74387..a166821 100644 --- a/package/jemalloc/Config.in +++ b/package/jemalloc/Config.in @@ -1,5 +1,15 @@ +config BR2_PACKAGE_JEMALLOC_ARCH_SUPPORTS + bool + default y if BR2_arm || BR2_armeb || BR2_aarch64 || BR2_aarch64_be + default y if BR2_i386 || BR2_x86_64 + default y if BR2_mips || BR2_mipsel + default y if BR2_sparc64 + default y if BR2_powerpc + default y if BR2_sh && !BR2_sh2a + config BR2_PACKAGE_JEMALLOC bool "jemalloc" + depends on BR2_PACKAGE_JEMALLOC_ARCH_SUPPORTS depends on !BR2_STATIC_LIBS help This library providing a malloc(3) implementation that emphasizes @@ -8,4 +18,5 @@ config BR2_PACKAGE_JEMALLOC http://www.canonware.com/jemalloc/ comment "jemalloc needs a toolchain w/ dynamic library" + depends on BR2_PACKAGE_JEMALLOC_ARCH_SUPPORTS depends on BR2_STATIC_LIBS
jemalloc has a hard-coded list of supported architectures, which it uses to define the minimum alignment for allocations. It whines at build time (not at configure time) when it does not know that alignment. Fix that by making jemalloc depend on the known-supported architectures. Fixes: http://autobuild.buildroot.org/results/674/674b6022f9a403528a758c0785656d2bda79e0a9/ Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr> --- package/jemalloc/Config.in | 11 +++++++++++ 1 file changed, 11 insertions(+)