diff mbox

[1/2] package/boost: boost-local needs NTPL threads

Message ID 1467469950-11984-1-git-send-email-romain.naour@smile.fr
State Rejected
Headers show

Commit Message

Romain Naour July 2, 2016, 2:32 p.m. UTC
Since Boost 1.61.0 boost-local require a toolchain with NTPL threads
support.

Fixes:
http://autobuild.buildroot.net/results/52c/52c198457c6a7a0a73766e8b8bed8d70997b80c0

Signed-off-by: Romain Naour <romain.naour@smile.fr>
---
 package/boost/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Bernd Kuhls July 2, 2016, 2:43 p.m. UTC | #1
Hi Romain,

Am Sat, 02 Jul 2016 16:32:29 +0200 schrieb Romain Naour:

> Since Boost 1.61.0 boost-local require a toolchain with NTPL threads
> support.

NAK, the Cortex m4 toolchain is broken, not boost:
http://lists.busybox.net/pipermail/buildroot/2016-June/163865.html

Regards, Bernd
Romain Naour July 2, 2016, 3:16 p.m. UTC | #2
Hi Bernd,

Le 02/07/2016 à 16:43, Bernd Kuhls a écrit :
> Hi Romain,
> 
> Am Sat, 02 Jul 2016 16:32:29 +0200 schrieb Romain Naour:
> 
>> Since Boost 1.61.0 boost-local require a toolchain with NTPL threads
>> support.
> 
> NAK, the Cortex m4 toolchain is broken, not boost:
> http://lists.busybox.net/pipermail/buildroot/2016-June/163865.html

Thanks for the link.
I guess the patch 2/2 has the same issue on NTPL requirement.
Still we probably need the library handling in the packaging.

Is the patch from Waldemar has been merged upstream ?
For now, can we add an autobuilder exception ?

I'll mark the series rejected.

Best regards,
Romain

> 
> Regards, Bernd
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
Waldemar Brodkorb July 2, 2016, 6:54 p.m. UTC | #3
Hi,
Romain Naour wrote,

> Hi Bernd,
> 
> Le 02/07/2016 à 16:43, Bernd Kuhls a écrit :
> > Hi Romain,
> > 
> > Am Sat, 02 Jul 2016 16:32:29 +0200 schrieb Romain Naour:
> > 
> >> Since Boost 1.61.0 boost-local require a toolchain with NTPL threads
> >> support.
> > 
> > NAK, the Cortex m4 toolchain is broken, not boost:
> > http://lists.busybox.net/pipermail/buildroot/2016-June/163865.html
> 
> Thanks for the link.
> I guess the patch 2/2 has the same issue on NTPL requirement.
> Still we probably need the library handling in the packaging.
> 
> Is the patch from Waldemar has been merged upstream ?
> For now, can we add an autobuilder exception ?

I have sent a official patch today to buildroot and reported the
issue upstream.

best regards
 Waldemar
Romain Naour July 3, 2016, 1:14 p.m. UTC | #4
Hi Waldemar,

Le 02/07/2016 à 20:54, Waldemar Brodkorb a écrit :
> Hi,
> Romain Naour wrote,
> 
>> Hi Bernd,
>>
>> Le 02/07/2016 à 16:43, Bernd Kuhls a écrit :
>>> Hi Romain,
>>>
>>> Am Sat, 02 Jul 2016 16:32:29 +0200 schrieb Romain Naour:
>>>
>>>> Since Boost 1.61.0 boost-local require a toolchain with NTPL threads
>>>> support.
>>>
>>> NAK, the Cortex m4 toolchain is broken, not boost:
>>> http://lists.busybox.net/pipermail/buildroot/2016-June/163865.html
>>
>> Thanks for the link.
>> I guess the patch 2/2 has the same issue on NTPL requirement.
>> Still we probably need the library handling in the packaging.
>>
>> Is the patch from Waldemar has been merged upstream ?
>> For now, can we add an autobuilder exception ?
> 
> I have sent a official patch today to buildroot and reported the
> issue upstream.

Thank you for the patch, Thomas is looking at it.

Best regards,
Romain

> 
> best regards
>  Waldemar
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
diff mbox

Patch

diff --git a/package/boost/Config.in b/package/boost/Config.in
index 0cc9a58..d47bb40 100644
--- a/package/boost/Config.in
+++ b/package/boost/Config.in
@@ -98,8 +98,12 @@  config BR2_PACKAGE_BOOST_IOSTREAMS
 
 config BR2_PACKAGE_BOOST_LOCALE
 	bool "boost-locale"
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
 
+comment "boost-locale needs a toolchain w/ NPTL"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
+
 config BR2_PACKAGE_BOOST_LOG
 	bool "boost-log"
 	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL