| Message ID | 1466736201-17310-1-git-send-email-Aduskett@gmail.com |
|---|---|
| State | Rejected, archived |
| Headers | show |
Hello, The title should always contain the package being affected by the change. I.e, it should be of the form: <package>: <description> In your case: busybox: ... On Thu, 23 Jun 2016 22:43:16 -0400, Adam Duskett wrote: > config BR2_PACKAGE_BUSYBOX_SELINUX > - select BR2_PACKAGE_LIBSELINUX > + depends on BR2_PACKAGE_LIBSELINUX Why are you doing this? A select is what's appropriate. > + depends on BR2_PACKAGE_LIBSEPOL Why are you adding this? libselinux already selects libsepol, so when you have libselinux, you have libsepol. Therefore, this patch looks bogus :-/ Thomas
diff --git a/package/busybox/Config.in b/package/busybox/Config.in index a3a328d..b7d6c13 100644 --- a/package/busybox/Config.in +++ b/package/busybox/Config.in @@ -33,7 +33,8 @@ config BR2_PACKAGE_BUSYBOX_SHOW_OTHERS by busybox. config BR2_PACKAGE_BUSYBOX_SELINUX - select BR2_PACKAGE_LIBSELINUX + depends on BR2_PACKAGE_LIBSELINUX + depends on BR2_PACKAGE_LIBSEPOL depends on BR2_TOOLCHAIN_HAS_THREADS depends on !BR2_STATIC_LIBS depends on !BR2_arc @@ -51,6 +52,9 @@ config BR2_PACKAGE_BUSYBOX_SELINUX crond, then individual binaries have to be enabled for the SELinux type transitions to occur properly. + comment "SELinux support in BusyBox requires libselinux, libsepol" + depends on !BR2_PACKAGE_LIBSELINUX || !BR2_PACKAGE_LIBSEPOL + config BR2_PACKAGE_BUSYBOX_WATCHDOG bool "Install the watchdog daemon startup script" help
Signed-off-by: Adam Duskett <Aduskett@gmail.com> --- package/busybox/Config.in | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)