| Message ID | fc45f1eb2c78908429ed2dd0551097a3df653ccf.1466622379.git.yann.morin.1998@free.fr |
|---|---|
| State | Changes Requested |
| Headers | show |
Yann, Le 22/06/2016 à 21:07, Yann E. MORIN a écrit : > Being custom means that our default one is not suitable to start with. > > So there is no reson to offer it as the default path. > > Add a separating empty line, for good measure, too. > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > --- > system/Config.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/system/Config.in b/system/Config.in > index 4f9f270..04b886b 100644 > --- a/system/Config.in > +++ b/system/Config.in > @@ -179,9 +179,9 @@ config BR2_ROOTFS_SKELETON_CUSTOM > endchoice > > if BR2_ROOTFS_SKELETON_CUSTOM > + > config BR2_ROOTFS_SKELETON_CUSTOM_PATH > string "custom target skeleton path" > - default "system/skeleton" Then, I think we should add a check in skeleton.mk if BR2_ROOTFS_SKELETON_CUSTOM_PATH is not empty and print an explicit error message. Best regards, Romain > help > Path to custom target skeleton. > >
On 03-07-16 10:42, Romain Naour wrote: > Yann, > > Le 22/06/2016 à 21:07, Yann E. MORIN a écrit : >> Being custom means that our default one is not suitable to start with. >> >> So there is no reson to offer it as the default path. >> >> Add a separating empty line, for good measure, too. >> >> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> >> --- >> system/Config.in | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/system/Config.in b/system/Config.in >> index 4f9f270..04b886b 100644 >> --- a/system/Config.in >> +++ b/system/Config.in >> @@ -179,9 +179,9 @@ config BR2_ROOTFS_SKELETON_CUSTOM >> endchoice >> >> if BR2_ROOTFS_SKELETON_CUSTOM >> + >> config BR2_ROOTFS_SKELETON_CUSTOM_PATH >> string "custom target skeleton path" >> - default "system/skeleton" > > Then, I think we should add a check in skeleton.mk if > BR2_ROOTFS_SKELETON_CUSTOM_PATH is not empty and print an explicit error message. +1 to that. I checked, we don't have it at the moment. Regards, Arnout > > Best regards, > Romain > > >> help >> Path to custom target skeleton. >> >> > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot >
Romain, All, On 2016-07-03 10:42 +0200, Romain Naour spake thusly: > Le 22/06/2016 à 21:07, Yann E. MORIN a écrit : > > Being custom means that our default one is not suitable to start with. > > > > So there is no reson to offer it as the default path. > > > > Add a separating empty line, for good measure, too. > > > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > > --- > > system/Config.in | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/system/Config.in b/system/Config.in > > index 4f9f270..04b886b 100644 > > --- a/system/Config.in > > +++ b/system/Config.in > > @@ -179,9 +179,9 @@ config BR2_ROOTFS_SKELETON_CUSTOM > > endchoice > > > > if BR2_ROOTFS_SKELETON_CUSTOM > > + > > config BR2_ROOTFS_SKELETON_CUSTOM_PATH > > string "custom target skeleton path" > > - default "system/skeleton" > > Then, I think we should add a check in skeleton.mk if > BR2_ROOTFS_SKELETON_CUSTOM_PATH is not empty and print an explicit error message. ACK. Regards, Yann E. MORIN. > Best regards, > Romain > > > > help > > Path to custom target skeleton. > > > > >
Hello, On Wed, 22 Jun 2016 21:07:29 +0200, Yann E. MORIN wrote: > Being custom means that our default one is not suitable to start with. > > So there is no reson to offer it as the default path. > > Add a separating empty line, for good measure, too. > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Looks good, but I'll wait for a respin with the check that the path is not empty. Thomas
diff --git a/system/Config.in b/system/Config.in index 4f9f270..04b886b 100644 --- a/system/Config.in +++ b/system/Config.in @@ -179,9 +179,9 @@ config BR2_ROOTFS_SKELETON_CUSTOM endchoice if BR2_ROOTFS_SKELETON_CUSTOM + config BR2_ROOTFS_SKELETON_CUSTOM_PATH string "custom target skeleton path" - default "system/skeleton" help Path to custom target skeleton.
Being custom means that our default one is not suitable to start with. So there is no reson to offer it as the default path. Add a separating empty line, for good measure, too. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> --- system/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)