| Message ID | 1465917079-30473-3-git-send-email-gilles.chanteperdrix@xenomai.org |
|---|---|
| State | Changes Requested |
| Headers | show |
Hello, On Tue, 14 Jun 2016 17:11:17 +0200, Gilles Chanteperdrix wrote: > diff --git a/package/pkg-download.mk b/package/pkg-download.mk > index a0f694d..5f7a155 100644 > --- a/package/pkg-download.mk > +++ b/package/pkg-download.mk > @@ -225,7 +225,7 @@ define DOWNLOAD_INNER > fi ; \ > if test -n "$(1)" ; then \ > case "$($(PKG)_SITE_METHOD)" in \ > - git) $($(3)_GIT) && exit ;; \ > + git|ssh) $($(3)_GIT) && exit ;; \ There has already been a question from Yann on a previous iteration of this patch, which hasn't been answered: """ What about Hg URLs that can also start with 'ssh://' ? """ Indeed, I don't see why a ssh:// URL should necessarily reference a Git repository. And there's no explanation about this decision in the commit log. Thanks, Thomas
On Wed, Jun 15, 2016 at 11:08:08PM +0200, Thomas Petazzoni wrote: > Hello, > > On Tue, 14 Jun 2016 17:11:17 +0200, Gilles Chanteperdrix wrote: > > > diff --git a/package/pkg-download.mk b/package/pkg-download.mk > > index a0f694d..5f7a155 100644 > > --- a/package/pkg-download.mk > > +++ b/package/pkg-download.mk > > @@ -225,7 +225,7 @@ define DOWNLOAD_INNER > > fi ; \ > > if test -n "$(1)" ; then \ > > case "$($(PKG)_SITE_METHOD)" in \ > > - git) $($(3)_GIT) && exit ;; \ > > + git|ssh) $($(3)_GIT) && exit ;; \ > > There has already been a question from Yann on a previous iteration of > this patch, which hasn't been answered: > > """ > What about Hg URLs that can also start with 'ssh://' ? > """ > > Indeed, I don't see why a ssh:// URL should necessarily reference a Git > repository. And there's no explanation about this decision in the > commit log. See the discussion here: http://lists.busybox.net/pipermail/buildroot/2016-May/160670.html
Hello, On Thu, 16 Jun 2016 21:40:24 +0200, Gilles Chanteperdrix wrote: > > """ > > What about Hg URLs that can also start with 'ssh://' ? > > """ > > > > Indeed, I don't see why a ssh:// URL should necessarily reference a Git > > repository. And there's no explanation about this decision in the > > commit log. > > See the discussion here: > http://lists.busybox.net/pipermail/buildroot/2016-May/160670.html I might be missing something, but I don't see anything in this discussion that gives a justification as to why ssh:// in Buildroot should always mean "git over ssh" and not potentially "mercurial over ssh" or "subversion over ssh". Thanks, Thomas
diff --git a/package/pkg-download.mk b/package/pkg-download.mk index a0f694d..5f7a155 100644 --- a/package/pkg-download.mk +++ b/package/pkg-download.mk @@ -225,7 +225,7 @@ define DOWNLOAD_INNER fi ; \ if test -n "$(1)" ; then \ case "$($(PKG)_SITE_METHOD)" in \ - git) $($(3)_GIT) && exit ;; \ + git|ssh) $($(3)_GIT) && exit ;; \ svn) $($(3)_SVN) && exit ;; \ cvs) $($(3)_CVS) && exit ;; \ bzr) $($(3)_BZR) && exit ;; \
Use git when such an URL is met. Signed-off-by: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org> --- package/pkg-download.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)