| Message ID | 20160530063606.GB31737@airbook.vandijck-laurijssen.be |
|---|---|
| State | Changes Requested |
| Headers | show |
Hello Kurt, On Mon, 30 May 2016 08:36:06 +0200, Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be> wrote: > Inputevent is an input-device to ascii tranlator. s/tranlator/translator/? Regards, Peter > Its output is of the format 'TIME CODE VALUE' and it's easy > to pipe it into a shell script. > > Signed-off-by: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be> > --- > package/Config.in | 1 + > package/inputevent/Config.in | 6 ++++++ > package/inputevent/inputevent.mk | 36 ++++++++++++++++++++++++++++++++++++ > 3 files changed, 43 insertions(+) > create mode 100644 package/inputevent/Config.in > create mode 100644 package/inputevent/inputevent.mk > > diff --git a/package/Config.in b/package/Config.in > index 529ad33..112e516 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -383,6 +383,7 @@ endif > source "package/i2c-tools/Config.in" > source "package/input-event-daemon/Config.in" > source "package/input-tools/Config.in" > + source "package/inputevent/Config.in" > source "package/intel-microcode/Config.in" > source "package/iostat/Config.in" > source "package/ipmitool/Config.in" > diff --git a/package/inputevent/Config.in b/package/inputevent/Config.in > new file mode 100644 > index 0000000..44422a3 > --- /dev/null > +++ b/package/inputevent/Config.in > @@ -0,0 +1,6 @@ > +config BR2_PACKAGE_INPUTEVENT > + bool "inputevent" > + help > + inputevent is a simple program that traces input events. > + When piped to a another program or script, you get similar > + functionality as input-event-daemon. > diff --git a/package/inputevent/inputevent.mk b/package/inputevent/inputevent.mk > new file mode 100644 > index 0000000..14a8d31 > --- /dev/null > +++ b/package/inputevent/inputevent.mk > @@ -0,0 +1,36 @@ > +################################################################################ > +# > +# inputevent > +# > +################################################################################ > + > +INPUTEVENT_VERSION = r8 > +INPUTEVENT_SITE = git://github.com/kurt-vd/inputevent.git > +INPUTEVENT_LICENSE = GPLv3 > +INPUTEVENT_LICENSE_FILES = LICENSE > + > +define INPUTEVENT_CONFIGURE_CMDS > + echo "PREFIX=/" > $(@D)/config.mk > + echo "CFLAGS=$(TARGET_CFLAGS)" >> $(@D)/config.mk > + echo "CPPFLAGS=-D_GNU_SOURCE $(TARGET_CPPFLAGS)" >> $(@D)/config.mk > + echo "CXXFLAGS=$(TARGET_CXXFLAGS)" >> $(@D)/config.mk > + echo "LDFLAGS=$(TARGET_LDFLAGS)" >> $(@D)/config.mk > + echo "LDLIBS+=$(TARGET_LDLIBS)" >> $(@D)/config.mk > + echo "CC=$(TARGET_CC)" >> $(@D)/config.mk > + echo "CXX=$(TARGET_CXX)" >> $(@D)/config.mk > + echo "LD=$(TARGET_LD)" >> $(@D)/config.mk > + echo "AS=$(TARGET_AS)" >> $(@D)/config.mk > + > + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) clean > +endef > + > +define INPUTEVENT_BUILD_CMDS > + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) > +endef > + > +define INPUTEVENT_INSTALL_TARGET_CMDS > + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) install DESTDIR="$(TARGET_DIR)" > +endef > + > +$(eval $(generic-package)) > +#$(eval $(configmk-package))
> > Hello Kurt, > > On Mon, 30 May 2016 08:36:06 +0200, Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be> wrote: > > > Inputevent is an input-device to ascii tranlator. > > s/tranlator/translator/? of course :-) Thanks, Kurt
Hello, On Mon, 30 May 2016 08:36:06 +0200, Kurt Van Dijck wrote: > diff --git a/package/inputevent/Config.in b/package/inputevent/Config.in > new file mode 100644 > index 0000000..44422a3 > --- /dev/null > +++ b/package/inputevent/Config.in > @@ -0,0 +1,6 @@ > +config BR2_PACKAGE_INPUTEVENT > + bool "inputevent" > + help > + inputevent is a simple program that traces input events. > + When piped to a another program or script, you get similar > + functionality as input-event-daemon. I certainly don't want to diminish the value of your contribution, but I am wondering what is the usefulness of this program, if it essentially does the same thing as existing programs? Your description itself shows that it is the same as input-event-daemon when piped into another program. And when not piped to another program, my feeling is that it does the same job as evtest. I'm happy with adding more and more packages in Buildroot, but we might have to draw the line on which packages we want to accept, and maybe ensure there are at least useful to more persons than just the developer who wrote the program/library. In any case, you should add the upstream URL of the project here in the Config.in help text, separated from the rest of the description by an empty line (see all other Config.in files for packages in Buildroot). > diff --git a/package/inputevent/inputevent.mk b/package/inputevent/inputevent.mk > new file mode 100644 > index 0000000..14a8d31 > --- /dev/null > +++ b/package/inputevent/inputevent.mk > @@ -0,0 +1,36 @@ > +################################################################################ > +# > +# inputevent > +# > +################################################################################ > + > +INPUTEVENT_VERSION = r8 > +INPUTEVENT_SITE = git://github.com/kurt-vd/inputevent.git Please use the github macro, and add a hash file. > +INPUTEVENT_LICENSE = GPLv3 > +INPUTEVENT_LICENSE_FILES = LICENSE > + > +define INPUTEVENT_CONFIGURE_CMDS > + echo "PREFIX=/" > $(@D)/config.mk > + echo "CFLAGS=$(TARGET_CFLAGS)" >> $(@D)/config.mk > + echo "CPPFLAGS=-D_GNU_SOURCE $(TARGET_CPPFLAGS)" >> $(@D)/config.mk > + echo "CXXFLAGS=$(TARGET_CXXFLAGS)" >> $(@D)/config.mk > + echo "LDFLAGS=$(TARGET_LDFLAGS)" >> $(@D)/config.mk > + echo "LDLIBS+=$(TARGET_LDLIBS)" >> $(@D)/config.mk There is no variable named TARGET_LDLIBS in Buildroot. > + echo "CC=$(TARGET_CC)" >> $(@D)/config.mk > + echo "CXX=$(TARGET_CXX)" >> $(@D)/config.mk > + echo "LD=$(TARGET_LD)" >> $(@D)/config.mk > + echo "AS=$(TARGET_AS)" >> $(@D)/config.mk This seems not needed, just pass all the necessary values in the environment. Also, PREFIX should be /usr. > + > + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) clean Not needed. > +endef > + > +define INPUTEVENT_BUILD_CMDS > + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) Just do: $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) PREFIX=/usr -C $(@D) TARGET_CONFIGURE_OPTS contains the definition of CFLAGS, CPPFLAGS, CXXFLAGS, CC, CXX, LD, AS and more. > +endef > + > +define INPUTEVENT_INSTALL_TARGET_CMDS > + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) install DESTDIR="$(TARGET_DIR)" > +endef > + > +$(eval $(generic-package)) > +#$(eval $(configmk-package)) This last line is not needed. Best regards, Thomas
diff --git a/package/Config.in b/package/Config.in index 529ad33..112e516 100644 --- a/package/Config.in +++ b/package/Config.in @@ -383,6 +383,7 @@ endif source "package/i2c-tools/Config.in" source "package/input-event-daemon/Config.in" source "package/input-tools/Config.in" + source "package/inputevent/Config.in" source "package/intel-microcode/Config.in" source "package/iostat/Config.in" source "package/ipmitool/Config.in" diff --git a/package/inputevent/Config.in b/package/inputevent/Config.in new file mode 100644 index 0000000..44422a3 --- /dev/null +++ b/package/inputevent/Config.in @@ -0,0 +1,6 @@ +config BR2_PACKAGE_INPUTEVENT + bool "inputevent" + help + inputevent is a simple program that traces input events. + When piped to a another program or script, you get similar + functionality as input-event-daemon. diff --git a/package/inputevent/inputevent.mk b/package/inputevent/inputevent.mk new file mode 100644 index 0000000..14a8d31 --- /dev/null +++ b/package/inputevent/inputevent.mk @@ -0,0 +1,36 @@ +################################################################################ +# +# inputevent +# +################################################################################ + +INPUTEVENT_VERSION = r8 +INPUTEVENT_SITE = git://github.com/kurt-vd/inputevent.git +INPUTEVENT_LICENSE = GPLv3 +INPUTEVENT_LICENSE_FILES = LICENSE + +define INPUTEVENT_CONFIGURE_CMDS + echo "PREFIX=/" > $(@D)/config.mk + echo "CFLAGS=$(TARGET_CFLAGS)" >> $(@D)/config.mk + echo "CPPFLAGS=-D_GNU_SOURCE $(TARGET_CPPFLAGS)" >> $(@D)/config.mk + echo "CXXFLAGS=$(TARGET_CXXFLAGS)" >> $(@D)/config.mk + echo "LDFLAGS=$(TARGET_LDFLAGS)" >> $(@D)/config.mk + echo "LDLIBS+=$(TARGET_LDLIBS)" >> $(@D)/config.mk + echo "CC=$(TARGET_CC)" >> $(@D)/config.mk + echo "CXX=$(TARGET_CXX)" >> $(@D)/config.mk + echo "LD=$(TARGET_LD)" >> $(@D)/config.mk + echo "AS=$(TARGET_AS)" >> $(@D)/config.mk + + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) clean +endef + +define INPUTEVENT_BUILD_CMDS + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) +endef + +define INPUTEVENT_INSTALL_TARGET_CMDS + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) install DESTDIR="$(TARGET_DIR)" +endef + +$(eval $(generic-package)) +#$(eval $(configmk-package))
Inputevent is an input-device to ascii tranlator. Its output is of the format 'TIME CODE VALUE' and it's easy to pipe it into a shell script. Signed-off-by: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be> --- package/Config.in | 1 + package/inputevent/Config.in | 6 ++++++ package/inputevent/inputevent.mk | 36 ++++++++++++++++++++++++++++++++++++ 3 files changed, 43 insertions(+) create mode 100644 package/inputevent/Config.in create mode 100644 package/inputevent/inputevent.mk