diff mbox

[v2] python-backports-abc: depend on Python 2.x

Message ID 1463641229-6426-1-git-send-email-yegorslists@googlemail.com
State Accepted
Headers show

Commit Message

Yegor Yefremov May 19, 2016, 7 a.m. UTC 
From: Yegor Yefremov <yegorslists@googlemail.com>

This package is a backport from Python 3.5, so it is not needed
for Python 3.5.x environment.

Fix python-tornado dependecies, so that python-backports-abc
is only selected for Python 2.x.

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
Changes:
	v2: sqaush both commits into one (Arnout Vandecappelle)

 package/python-backports-abc/Config.in | 1 +
 package/python-tornado/Config.in       | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

Comments

Thomas Petazzoni May 23, 2016, 3:08 p.m. UTC | #1 
Hello,

On Thu, 19 May 2016 09:00:29 +0200, yegorslists@googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> This package is a backport from Python 3.5, so it is not needed
> for Python 3.5.x environment.
> 
> Fix python-tornado dependecies, so that python-backports-abc
> is only selected for Python 2.x.
> 
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
> Changes:
> 	v2: sqaush both commits into one (Arnout Vandecappelle)

I've applied to next, because Python 3.5 is only in next. Let me know
if I misunderstood something.

Thanks!

Thomas
Yegor Yefremov May 23, 2016, 4:44 p.m. UTC | #2 
On Mon, May 23, 2016 at 5:08 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Thu, 19 May 2016 09:00:29 +0200, yegorslists@googlemail.com wrote:
>> From: Yegor Yefremov <yegorslists@googlemail.com>
>>
>> This package is a backport from Python 3.5, so it is not needed
>> for Python 3.5.x environment.
>>
>> Fix python-tornado dependecies, so that python-backports-abc
>> is only selected for Python 2.x.
>>
>> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>> ---
>> Changes:
>>       v2: sqaush both commits into one (Arnout Vandecappelle)
>
> I've applied to next, because Python 3.5 is only in next. Let me know
> if I misunderstood something.

No. next is the right branch. I just forgot to mention in the subject.

Yegor
diff mbox

Patch

diff --git a/package/python-backports-abc/Config.in b/package/python-backports-abc/Config.in
index 26d8cfd..4356627 100644
--- a/package/python-backports-abc/Config.in
+++ b/package/python-backports-abc/Config.in
@@ -1,5 +1,6 @@ 
 config BR2_PACKAGE_PYTHON_BACKPORTS_ABC
 	bool "python-backports-abc"
+	depends on BR2_PACKAGE_PYTHON
 	help
 	  A backport of recent additions to the 'collections.abc'
 	  module.
diff --git a/package/python-tornado/Config.in b/package/python-tornado/Config.in
index ac86682..3ead2af 100644
--- a/package/python-tornado/Config.in
+++ b/package/python-tornado/Config.in
@@ -3,7 +3,7 @@  config BR2_PACKAGE_PYTHON_TORNADO
 	select BR2_PACKAGE_PYTHON_ZLIB if BR2_PACKAGE_PYTHON # runtime
 	select BR2_PACKAGE_PYTHON3_ZLIB if BR2_PACKAGE_PYTHON3 # runtime
 	select BR2_PACKAGE_PYTHON_SINGLEDISPATCH if BR2_PACKAGE_PYTHON # runtime
-	select BR2_PACKAGE_PYTHON_BACKPORTS_ABC	# runtime
+	select BR2_PACKAGE_PYTHON_BACKPORTS_ABC	if BR2_PACKAGE_PYTHON # runtime
 	help
 	  Tornado is a Python web framework and asynchronous networking
 	  library, originally developed at FriendFeed.