| Message ID | 1461268365-13922-1-git-send-email-thomas.petazzoni@free-electrons.com |
|---|---|
| State | Accepted |
| Headers | show |
On 04/21/16 21:52, Thomas Petazzoni wrote: > We were not defining BR2_ARCH for two of the x86 subarchitecture, > which means the architecture part of the GNU_TARGET_NAME tuple was > empty, leading to weird build failures. > > This commit fixes that by defining the appropriate values. > > Fixes bug #8861. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> It would be nice if we would have a way to check something like that... Regards, Arnout > --- > arch/Config.in.x86 | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/Config.in.x86 b/arch/Config.in.x86 > index 4039db8..efa9567 100644 > --- a/arch/Config.in.x86 > +++ b/arch/Config.in.x86 > @@ -226,6 +226,8 @@ config BR2_ARCH > default "i686" if BR2_x86_nocona && BR2_i386 > default "i686" if BR2_x86_core2 && BR2_i386 > default "i686" if BR2_x86_corei7 && BR2_i386 > + default "i686" if BR2_x86_corei7_avx && BR2_i386 > + default "i686" if BR2_x86_corei7_avx2 && BR2_i386 > default "i686" if BR2_x86_atom && BR2_i386 > default "i686" if BR2_x86_opteron && BR2_i386 > default "i686" if BR2_x86_opteron_sse3 && BR2_i386 >
Hello, On Thu, 21 Apr 2016 22:57:21 +0200, Arnout Vandecappelle wrote: > Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Thanks! > It would be nice if we would have a way to check something like that... ifeq ($(call qstrip,$(BR2_ARCH)),) $(error Blurp!) endif ? Thomas
On 04/21/16 23:02, Thomas Petazzoni wrote: > Hello, > > On Thu, 21 Apr 2016 22:57:21 +0200, Arnout Vandecappelle wrote: > >> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> > > Thanks! > >> It would be nice if we would have a way to check something like that... > > ifeq ($(call qstrip,$(BR2_ARCH)),) > $(error Blurp!) > endif I meant statically, somehow. This will only be hit by users who actually select that arch option, not by autobuilders. Regards, Arnout > > ? > > Thomas >
diff --git a/arch/Config.in.x86 b/arch/Config.in.x86 index 4039db8..efa9567 100644 --- a/arch/Config.in.x86 +++ b/arch/Config.in.x86 @@ -226,6 +226,8 @@ config BR2_ARCH default "i686" if BR2_x86_nocona && BR2_i386 default "i686" if BR2_x86_core2 && BR2_i386 default "i686" if BR2_x86_corei7 && BR2_i386 + default "i686" if BR2_x86_corei7_avx && BR2_i386 + default "i686" if BR2_x86_corei7_avx2 && BR2_i386 default "i686" if BR2_x86_atom && BR2_i386 default "i686" if BR2_x86_opteron && BR2_i386 default "i686" if BR2_x86_opteron_sse3 && BR2_i386
We were not defining BR2_ARCH for two of the x86 subarchitecture, which means the architecture part of the GNU_TARGET_NAME tuple was empty, leading to weird build failures. This commit fixes that by defining the appropriate values. Fixes bug #8861. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- arch/Config.in.x86 | 2 ++ 1 file changed, 2 insertions(+)