| Message ID | 1457660040-13917-1-git-send-email-jcmvbkbc@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
Max, All, On 2016-03-11 04:34 +0300, Max Filippov spake thusly: > This reverts commit c44cf2cc97df1729577263d2b0cb5263e8cdc4c1. > Now that xtensa gas don't move literals into .init and .fini this fix is > no longer needed. Do you have an upstream reference with that fix? Regards, Yann E. MORIN. > Signed-off-by: Max Filippov <jcmvbkbc@gmail.com> > --- > package/gcc/gcc.mk | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/package/gcc/gcc.mk b/package/gcc/gcc.mk > index 0fb73c9..5646b66 100644 > --- a/package/gcc/gcc.mk > +++ b/package/gcc/gcc.mk > @@ -97,13 +97,6 @@ HOST_GCC_COMMON_CONF_ENV = \ > GCC_COMMON_TARGET_CFLAGS = $(TARGET_CFLAGS) > GCC_COMMON_TARGET_CXXFLAGS = $(TARGET_CXXFLAGS) > > -# Xtensa libgcc can't be built with -mauto-litpools > -# because of the trick used to generate .init/.fini sections. > -ifeq ($(BR2_xtensa),y) > -GCC_COMMON_TARGET_CFLAGS = $(filter-out -mauto-litpools,$(TARGET_CFLAGS)) > -GCC_COMMON_TARGET_CXXFLAGS = $(filter-out -mauto-litpools,$(TARGET_CXXFLAGS)) > -endif > - > # Propagate options used for target software building to GCC target libs > HOST_GCC_COMMON_CONF_ENV += CFLAGS_FOR_TARGET="$(GCC_COMMON_TARGET_CFLAGS)" > HOST_GCC_COMMON_CONF_ENV += CXXFLAGS_FOR_TARGET="$(GCC_COMMON_TARGET_CXXFLAGS)" > -- > 2.1.4 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Hi Yann, On Sun, Mar 13, 2016 at 1:57 AM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > Max, All, > > On 2016-03-11 04:34 +0300, Max Filippov spake thusly: >> This reverts commit c44cf2cc97df1729577263d2b0cb5263e8cdc4c1. >> Now that xtensa gas don't move literals into .init and .fini this fix is >> no longer needed. > > Do you have an upstream reference with that fix? It's 4111950f363221c4641dc2f33bea61cc94f34906 , https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=4111950f363221c4641dc2f33bea61cc94f34906 backported to all supported binutils as *-xtensa-fix-.init-.fini-literals-moving.patch
Hello, On Fri, 11 Mar 2016 04:34:00 +0300, Max Filippov wrote: > This reverts commit c44cf2cc97df1729577263d2b0cb5263e8cdc4c1. > Now that xtensa gas don't move literals into .init and .fini this fix is > no longer needed. > > Signed-off-by: Max Filippov <jcmvbkbc@gmail.com> > --- > package/gcc/gcc.mk | 7 ------- > 1 file changed, 7 deletions(-) I've added a few more details in the commit, as suggested by Yann, and using the info you provided as a reply to Yann. Then I applied, of course. Thanks! Thomas
diff --git a/package/gcc/gcc.mk b/package/gcc/gcc.mk index 0fb73c9..5646b66 100644 --- a/package/gcc/gcc.mk +++ b/package/gcc/gcc.mk @@ -97,13 +97,6 @@ HOST_GCC_COMMON_CONF_ENV = \ GCC_COMMON_TARGET_CFLAGS = $(TARGET_CFLAGS) GCC_COMMON_TARGET_CXXFLAGS = $(TARGET_CXXFLAGS) -# Xtensa libgcc can't be built with -mauto-litpools -# because of the trick used to generate .init/.fini sections. -ifeq ($(BR2_xtensa),y) -GCC_COMMON_TARGET_CFLAGS = $(filter-out -mauto-litpools,$(TARGET_CFLAGS)) -GCC_COMMON_TARGET_CXXFLAGS = $(filter-out -mauto-litpools,$(TARGET_CXXFLAGS)) -endif - # Propagate options used for target software building to GCC target libs HOST_GCC_COMMON_CONF_ENV += CFLAGS_FOR_TARGET="$(GCC_COMMON_TARGET_CFLAGS)" HOST_GCC_COMMON_CONF_ENV += CXXFLAGS_FOR_TARGET="$(GCC_COMMON_TARGET_CXXFLAGS)"
This reverts commit c44cf2cc97df1729577263d2b0cb5263e8cdc4c1. Now that xtensa gas don't move literals into .init and .fini this fix is no longer needed. Signed-off-by: Max Filippov <jcmvbkbc@gmail.com> --- package/gcc/gcc.mk | 7 ------- 1 file changed, 7 deletions(-)