| Message ID | 1457317732-18406-43-git-send-email-sjg@chromium.org |
|---|---|
| State | Accepted |
| Commit | d116b53f873c2cba861a7a83f4693d65140989b6 |
| Delegated to: | Bin Meng |
| Headers | show |
On Mon, Mar 7, 2016 at 10:28 AM, Simon Glass <sjg@chromium.org> wrote: > The Intel SIPI (start-up inter-processor interrupt) vector is the entry > point for each secondary CPU (also called an AP - applications processor). > The assembler and C code are linked, so add comments to indicate this. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > arch/x86/cpu/sipi_vector.S | 1 + > arch/x86/include/asm/sipi.h | 1 + > 2 files changed, 2 insertions(+) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On Fri, Mar 11, 2016 at 3:01 PM, Bin Meng <bmeng.cn@gmail.com> wrote: > On Mon, Mar 7, 2016 at 10:28 AM, Simon Glass <sjg@chromium.org> wrote: >> The Intel SIPI (start-up inter-processor interrupt) vector is the entry >> point for each secondary CPU (also called an AP - applications processor). >> The assembler and C code are linked, so add comments to indicate this. >> >> Signed-off-by: Simon Glass <sjg@chromium.org> >> --- >> >> arch/x86/cpu/sipi_vector.S | 1 + >> arch/x86/include/asm/sipi.h | 1 + >> 2 files changed, 2 insertions(+) >> > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> applied to u-boot-x86/next, thanks!
diff --git a/arch/x86/cpu/sipi_vector.S b/arch/x86/cpu/sipi_vector.S index 0c4a157..94c0f5a 100644 --- a/arch/x86/cpu/sipi_vector.S +++ b/arch/x86/cpu/sipi_vector.S @@ -193,6 +193,7 @@ load_msr: mov c_handler, %esi call *%esi + /* This matches struct sipi_param */ .align 4 .globl sipi_params sipi_params: diff --git a/arch/x86/include/asm/sipi.h b/arch/x86/include/asm/sipi.h index 25d7d31..da91a48 100644 --- a/arch/x86/include/asm/sipi.h +++ b/arch/x86/include/asm/sipi.h @@ -42,6 +42,7 @@ struct __packed sipi_params_16bit { * struct sipi_params - 32-bit SIP entry-point parameters * * These are used by the AP init code and must be set up before the APs start. + * The members must match with the sipi_params layout in sipi_vector.S. * * The stack area extends down from @stack_top, with @stack_size allocated * for each AP.
The Intel SIPI (start-up inter-processor interrupt) vector is the entry point for each secondary CPU (also called an AP - applications processor). The assembler and C code are linked, so add comments to indicate this. Signed-off-by: Simon Glass <sjg@chromium.org> --- arch/x86/cpu/sipi_vector.S | 1 + arch/x86/include/asm/sipi.h | 1 + 2 files changed, 2 insertions(+)