| Message ID | 1453647303-3965-2-git-send-email-yba@tkos.co.il |
|---|---|
| State | Rejected |
| Headers | show |
Jonathan, On Sun, 24 Jan 2016 16:55:00 +0200, Jonathan Ben-Avraham wrote: > From: Jonathan Ben Avraham <yba@tkos.co.il> > > > Signed-off-by: Jonathan Ben Avraham <yba@tkos.co.il> > --- > package/Config.in | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/package/Config.in b/package/Config.in > index 09c2b40..af9656b 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -1482,6 +1482,8 @@ endif > source "package/xinetd/Config.in" > source "package/xl2tp/Config.in" > source "package/xtables-addons/Config.in" > + source "package/yp-tools/Config.in" > + source "package/ypbind-mt/Config.in" This should not be a separate patch. Instead, adding yp-tools to the menu should be part of the patch adding the yp-tools package, and adding ypbind-mt to the menu should be part of the patch adding the ypbind-mt package. Thanks! Thomas
On Sun, 24 Jan 2016, Thomas Petazzoni wrote: > Date: Sun, 24 Jan 2016 16:09:20 +0100 > From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > To: Jonathan Ben-Avraham <yba@tkos.co.il> > Cc: buildroot@busybox.net > Subject: Re: [Buildroot] [PATCH v4 1/4] Add yp-tools and ypbind-mt to packages > menu > > Jonathan, > > On Sun, 24 Jan 2016 16:55:00 +0200, Jonathan Ben-Avraham wrote: >> From: Jonathan Ben Avraham <yba@tkos.co.il> >> >> >> Signed-off-by: Jonathan Ben Avraham <yba@tkos.co.il> >> --- >> package/Config.in | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/package/Config.in b/package/Config.in >> index 09c2b40..af9656b 100644 >> --- a/package/Config.in >> +++ b/package/Config.in >> @@ -1482,6 +1482,8 @@ endif >> source "package/xinetd/Config.in" >> source "package/xl2tp/Config.in" >> source "package/xtables-addons/Config.in" >> + source "package/yp-tools/Config.in" >> + source "package/ypbind-mt/Config.in" > > This should not be a separate patch. Instead, adding yp-tools to the > menu should be part of the patch adding the yp-tools package, and > adding ypbind-mt to the menu should be part of the patch adding the > ypbind-mt package. That is, one patch should look something like source "package/xinetd/Config.in" source "package/xl2tp/Config.in" source "package/xtables-addons/Config.in" + source "package/yp-tools/Config.in" source "package/znc/Config.in" and the other should look like source "package/xinetd/Config.in" source "package/xl2tp/Config.in" source "package/xtables-addons/Config.in" + source "package/ypbind-mt/Config.in" source "package/znc/Config.in" ? And then we rely on the order of the application of the patches to determine the order of the items in the final Config.in? - yba > Thanks! > > Thomas >
Dear Jonathan Ben Avraham, On Sun, 24 Jan 2016 17:33:24 +0200 (IST), Jonathan Ben Avraham wrote: > That is, one patch should look something like > > source "package/xinetd/Config.in" > source "package/xl2tp/Config.in" > source "package/xtables-addons/Config.in" > + source "package/yp-tools/Config.in" > source "package/znc/Config.in" This change should be part of the patch adding package/yp-tools/. > and the other should look like > > source "package/xinetd/Config.in" > source "package/xl2tp/Config.in" > source "package/xtables-addons/Config.in" > + source "package/ypbind-mt/Config.in" > source "package/znc/Config.in" This change should be part of the patch adding package/ypbind-mt/ > And then we rely on the order of the application of the patches to > determine the order of the items in the final Config.in? Yes. A series is a list of patches that are ordered. They will be applied in the order they are listed in your series. Many series have patches that have dependencies between each other, that's the whole purpose of sending them as a series rather than independently. Thanks! Thomas
On Sun, 24 Jan 2016, Thomas Petazzoni wrote: > Date: Sun, 24 Jan 2016 16:38:27 +0100 > From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > To: Jonathan Ben Avraham <yba@tkos.co.il> > Cc: buildroot@busybox.net > Subject: Re: [Buildroot] [PATCH v4 1/4] Add yp-tools and ypbind-mt to packages > menu > > Dear Jonathan Ben Avraham, > > On Sun, 24 Jan 2016 17:33:24 +0200 (IST), Jonathan Ben Avraham wrote: > >> That is, one patch should look something like >> >> source "package/xinetd/Config.in" >> source "package/xl2tp/Config.in" >> source "package/xtables-addons/Config.in" >> + source "package/yp-tools/Config.in" >> source "package/znc/Config.in" > > This change should be part of the patch adding package/yp-tools/. > >> and the other should look like >> >> source "package/xinetd/Config.in" >> source "package/xl2tp/Config.in" >> source "package/xtables-addons/Config.in" >> + source "package/ypbind-mt/Config.in" >> source "package/znc/Config.in" > > This change should be part of the patch adding package/ypbind-mt/ > >> And then we rely on the order of the application of the patches to >> determine the order of the items in the final Config.in? > > Yes. A series is a list of patches that are ordered. They will be > applied in the order they are listed in your series. Many series have > patches that have dependencies between each other, that's the whole > purpose of sending them as a series rather than independently. Hi Thomas, Thanks. I was not aware of the use of patch order to determine the final outcome and so I intentionally created a series that could be applied in any order and still have the desired outcome. - yba > Thanks! > > Thomas >
diff --git a/package/Config.in b/package/Config.in index 09c2b40..af9656b 100644 --- a/package/Config.in +++ b/package/Config.in @@ -1482,6 +1482,8 @@ endif source "package/xinetd/Config.in" source "package/xl2tp/Config.in" source "package/xtables-addons/Config.in" + source "package/yp-tools/Config.in" + source "package/ypbind-mt/Config.in" source "package/znc/Config.in" endmenu