diff mbox

package/iprutils: disable for musl toolchains

Message ID 1453582679-30476-1-git-send-email-romain.naour@gmail.com
State Rejected
Headers show

Commit Message

Romain Naour Jan. 23, 2016, 8:57 p.m. UTC
Disable iprutils for musl toolchain until someone
is interested enough to fixes it.

Note: the latest version (2.4.10) doesn't event build
with uClibc due to a test in the new configure script.

AC_CHECK_LIB([m], [matherr], [], [AC_ERROR("libm not found.")])

Avoid:
http://autobuild.buildroot.net/results/61e/61e121c25fc07083bcccedfcb4f938d18f5c5456/

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
 package/iprutils/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Thomas Petazzoni Jan. 25, 2016, 10:29 p.m. UTC | #1
Dear Romain Naour,

On Sat, 23 Jan 2016 21:57:59 +0100, Romain Naour wrote:
> Disable iprutils for musl toolchain until someone
> is interested enough to fixes it.
> 
> Note: the latest version (2.4.10) doesn't event build
> with uClibc due to a test in the new configure script.
> 
> AC_CHECK_LIB([m], [matherr], [], [AC_ERROR("libm not found.")])
> 
> Avoid:
> http://autobuild.buildroot.net/results/61e/61e121c25fc07083bcccedfcb4f938d18f5c5456/
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>

Disabling on musl seems really excessive. I looked at the problem, and
by:

 * Removing the #include <bits/sockaddr.h> from iprlib.h

 * Adding #include <limits.h> to iprlib.h

I was able to build the iprutils package with the musl C library on ARM.

Could you look into this and cook a better patch ?

Thanks!

Thomas
diff mbox

Patch

diff --git a/package/iprutils/Config.in b/package/iprutils/Config.in
index 1bc58e8..709aee6 100644
--- a/package/iprutils/Config.in
+++ b/package/iprutils/Config.in
@@ -1,5 +1,6 @@ 
 config BR2_PACKAGE_IPRUTILS
 	bool "iprutils"
+	depends on !BR2_TOOLCHAIN_USES_MUSL
 	select BR2_PACKAGE_NCURSES
 	select BR2_PACKAGE_NCURSES_TARGET_PANEL
 	select BR2_PACKAGE_NCURSES_TARGET_FORM
@@ -11,3 +12,6 @@  config BR2_PACKAGE_IPRUTILS
 	  System utilities for IBM Power RAID devices
 
 	  http://sourceforge.net/projects/iprdd/
+
+comment "iprutils needs a glibc or uClibc toolchain"
+	depends on BR2_TOOLCHAIN_USES_MUSL