Message ID | 1453448992-20178-8-git-send-email-bhuvanchandra.dv@toradex.com |
---|---|
State | Superseded |
Delegated to: | Stefano Babic |
Headers | show |
Hi Bhuvanchandra, On Fri, Jan 22, 2016 at 3:49 PM, Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> wrote: > Let's go with pure DT solution! > Since in long run U-Boot anyway is evolving to pure DT solution. > --- > configs/colibri_vf_defconfig | 11 ----------- > configs/pcm052_defconfig | 6 ------ > configs/vf610twr_defconfig | 9 --------- > 3 files changed, 26 deletions(-) > delete mode 100644 configs/colibri_vf_defconfig > delete mode 100644 configs/pcm052_defconfig > delete mode 100644 configs/vf610twr_defconfig > If you chose updating existing defconfig files, I believe we don't need this patch. [snip] Regards, Bin
On 01/22/2016 03:25 PM, Bin Meng wrote: > Hi Bhuvanchandra, > > On Fri, Jan 22, 2016 at 3:49 PM, Bhuvanchandra DV > <bhuvanchandra.dv@toradex.com> wrote: >> Let's go with pure DT solution! >> Since in long run U-Boot anyway is evolving to pure DT solution. >> --- >> configs/colibri_vf_defconfig | 11 ----------- >> configs/pcm052_defconfig | 6 ------ >> configs/vf610twr_defconfig | 9 --------- >> 3 files changed, 26 deletions(-) >> delete mode 100644 configs/colibri_vf_defconfig >> delete mode 100644 configs/pcm052_defconfig >> delete mode 100644 configs/vf610twr_defconfig >> > > If you chose updating existing defconfig files, I believe we don't > need this patch. Okay. > > [snip] > > Regards, > Bin >
On 2016-01-22 04:21, Bhuvanchandra DV wrote: > On 01/22/2016 03:25 PM, Bin Meng wrote: >> Hi Bhuvanchandra, >> >> On Fri, Jan 22, 2016 at 3:49 PM, Bhuvanchandra DV >> <bhuvanchandra.dv@toradex.com> wrote: >>> Let's go with pure DT solution! >>> Since in long run U-Boot anyway is evolving to pure DT solution. >>> --- >>> configs/colibri_vf_defconfig | 11 ----------- >>> configs/pcm052_defconfig | 6 ------ >>> configs/vf610twr_defconfig | 9 --------- >>> 3 files changed, 26 deletions(-) >>> delete mode 100644 configs/colibri_vf_defconfig >>> delete mode 100644 configs/pcm052_defconfig >>> delete mode 100644 configs/vf610twr_defconfig >>> >> >> If you chose updating existing defconfig files, I believe we don't >> need this patch. > > Okay. > I agree with Bin, lets drop the dtb in the defconfigs. For colibri_vf, you probably should remove the colibri_vf_defconfig and rename colibri_vf_dtb_defconfig in a first patch, and then add the additional stuff in a later patch For the other boards, just use the defconfigs without dtb in it from start. -- Stefan >> >> [snip] >> >> Regards, >> Bin >>
diff --git a/configs/colibri_vf_defconfig b/configs/colibri_vf_defconfig deleted file mode 100644 index 45917c8..0000000 --- a/configs/colibri_vf_defconfig +++ /dev/null @@ -1,11 +0,0 @@ -CONFIG_ARM=y -CONFIG_TARGET_COLIBRI_VF=y -CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/toradex/colibri_vf/imximage.cfg,ENV_IS_IN_NAND,IMX_NAND" -CONFIG_SYS_PROMPT="Colibri VFxx # " -# CONFIG_CMD_IMLS is not set -CONFIG_CMD_GPIO=y -# CONFIG_CMD_SETEXPR is not set -CONFIG_DM=y -CONFIG_NAND_VF610_NFC=y -CONFIG_SYS_NAND_VF610_NFC_60_ECC_BYTES=y -CONFIG_FSL_LPUART=y diff --git a/configs/pcm052_defconfig b/configs/pcm052_defconfig deleted file mode 100644 index 26ab733..0000000 --- a/configs/pcm052_defconfig +++ /dev/null @@ -1,6 +0,0 @@ -CONFIG_ARM=y -CONFIG_TARGET_PCM052=y -CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/phytec/pcm052/imximage.cfg,ENV_IS_IN_NAND" -CONFIG_NAND_VF610_NFC=y -CONFIG_SYS_NAND_BUSWIDTH_16BIT=y -CONFIG_FSL_LPUART=y diff --git a/configs/vf610twr_defconfig b/configs/vf610twr_defconfig deleted file mode 100644 index d51c93b..0000000 --- a/configs/vf610twr_defconfig +++ /dev/null @@ -1,9 +0,0 @@ -CONFIG_ARM=y -CONFIG_TARGET_VF610TWR=y -CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/freescale/vf610twr/imximage.cfg,ENV_IS_IN_MMC" -# CONFIG_CMD_IMLS is not set -# CONFIG_CMD_SETEXPR is not set -CONFIG_NAND_VF610_NFC=y -CONFIG_SYS_NAND_BUSWIDTH_16BIT=y -CONFIG_SPI_FLASH=y -CONFIG_FSL_LPUART=y