diff mbox

[U-Boot,16/17] arm: ls1021atwr: Disable CONFIG_E1000 temporarily

Message ID 1452580888-27637-17-git-send-email-bmeng.cn@gmail.com
State Changes Requested
Delegated to: Joe Hershberger
Headers show

Commit Message

Bin Meng Jan. 12, 2016, 6:41 a.m. UTC
Before we switch to use driver model ethernet support, disable
CONFIG_E1000 temporarily as with driver model ethernet, E1000
driver depends on driver model PCI which is not ready on this
board yet.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 configs/ls1021atwr_nor_defconfig        | 1 -
 configs/ls1021atwr_nor_lpuart_defconfig | 1 -
 2 files changed, 2 deletions(-)

Comments

York Sun Jan. 12, 2016, 5:52 p.m. UTC | #1
On 01/11/2016 10:38 PM, Bin Meng wrote:
> Before we switch to use driver model ethernet support, disable
> CONFIG_E1000 temporarily as with driver model ethernet, E1000
> driver depends on driver model PCI which is not ready on this
> board yet.
> 

Any idea when PCI/E1000 can be enabled?

York
Bin Meng Jan. 13, 2016, 6:21 a.m. UTC | #2
Hi York,

On Wed, Jan 13, 2016 at 1:52 AM, York Sun <yorksun@freescale.com> wrote:
>
>
> On 01/11/2016 10:38 PM, Bin Meng wrote:
>> Before we switch to use driver model ethernet support, disable
>> CONFIG_E1000 temporarily as with driver model ethernet, E1000
>> driver depends on driver model PCI which is not ready on this
>> board yet.
>>
>
> Any idea when PCI/E1000 can be enabled?
>

Next on my todo list is to convert layerscape pcie to driver model.
But I suspect we should consolidate that driver with imx pcie driver
first.

Regards,
Bin
York Sun Jan. 13, 2016, 4:07 p.m. UTC | #3
On 01/12/2016 10:21 PM, Bin Meng wrote:
> Hi York,
> 
> On Wed, Jan 13, 2016 at 1:52 AM, York Sun <yorksun@freescale.com> wrote:
>>
>>
>> On 01/11/2016 10:38 PM, Bin Meng wrote:
>>> Before we switch to use driver model ethernet support, disable
>>> CONFIG_E1000 temporarily as with driver model ethernet, E1000
>>> driver depends on driver model PCI which is not ready on this
>>> board yet.
>>>
>>
>> Any idea when PCI/E1000 can be enabled?
>>
> 
> Next on my todo list is to convert layerscape pcie to driver model.
> But I suspect we should consolidate that driver with imx pcie driver
> first.
> 

The dilemma here is we heavily depend on the PCIe/e1000 for remote boards in our
boardfarms. Once this patch is merged, we will lose network under u-boot. The
network interfaces of LS1 itself are used for benchmark and other purpose. We
surely can reconfigure the boards but that impacts all the auto scripts.

I would prefer to have PCIe/e1000 working first.

York
Bin Meng Jan. 14, 2016, 1:57 a.m. UTC | #4
Hi York,

On Thu, Jan 14, 2016 at 12:07 AM, york sun <york.sun@nxp.com> wrote:
> On 01/12/2016 10:21 PM, Bin Meng wrote:
>> Hi York,
>>
>> On Wed, Jan 13, 2016 at 1:52 AM, York Sun <yorksun@freescale.com> wrote:
>>>
>>>
>>> On 01/11/2016 10:38 PM, Bin Meng wrote:
>>>> Before we switch to use driver model ethernet support, disable
>>>> CONFIG_E1000 temporarily as with driver model ethernet, E1000
>>>> driver depends on driver model PCI which is not ready on this
>>>> board yet.
>>>>
>>>
>>> Any idea when PCI/E1000 can be enabled?
>>>
>>
>> Next on my todo list is to convert layerscape pcie to driver model.
>> But I suspect we should consolidate that driver with imx pcie driver
>> first.
>>
>
> The dilemma here is we heavily depend on the PCIe/e1000 for remote boards in our
> boardfarms. Once this patch is merged, we will lose network under u-boot. The
> network interfaces of LS1 itself are used for benchmark and other purpose. We
> surely can reconfigure the boards but that impacts all the auto scripts.
>
> I would prefer to have PCIe/e1000 working first.
>

OK, will include PCIe DM conversion in v2.

Regards,
Bin
diff mbox

Patch

diff --git a/configs/ls1021atwr_nor_defconfig b/configs/ls1021atwr_nor_defconfig
index 2b79443..ddda0b8 100644
--- a/configs/ls1021atwr_nor_defconfig
+++ b/configs/ls1021atwr_nor_defconfig
@@ -6,5 +6,4 @@  CONFIG_DEFAULT_DEVICE_TREE="ls1021a-twr"
 CONFIG_OF_CONTROL=y
 CONFIG_DM=y
 CONFIG_NETDEVICES=y
-CONFIG_E1000=y
 CONFIG_SYS_NS16550=y
diff --git a/configs/ls1021atwr_nor_lpuart_defconfig b/configs/ls1021atwr_nor_lpuart_defconfig
index 5346359..3564736 100644
--- a/configs/ls1021atwr_nor_lpuart_defconfig
+++ b/configs/ls1021atwr_nor_lpuart_defconfig
@@ -7,5 +7,4 @@  CONFIG_SYS_EXTRA_OPTIONS="LPUART"
 CONFIG_OF_CONTROL=y
 CONFIG_DM=y
 CONFIG_NETDEVICES=y
-CONFIG_E1000=y
 CONFIG_FSL_LPUART=y