| Message ID | 1450689599-65471-1-git-send-email-yanmiaobest@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
On Mon, Dec 21, 2015 at 5:19 PM, Miao Yan <yanmiaobest@gmail.com> wrote: > In pci_map_region(), pass 'range_id' to fdt_read_range(), > otherwise the same address will be mapped again in other > calls to pci_map_region() > > Signed-off-by: Miao Yan <yammiaobest@gmail.com> > --- > board/freescale/qemu-ppce500/qemu-ppce500.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On 21.12.15 10:19, Miao Yan wrote: > In pci_map_region(), pass 'range_id' to fdt_read_range(), > otherwise the same address will be mapped again in other > calls to pci_map_region() > > Signed-off-by: Miao Yan <yammiaobest@gmail.com> Oops :). Reviewed-by: Alexander Graf <agraf@suse.de> Alex > --- > board/freescale/qemu-ppce500/qemu-ppce500.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/freescale/qemu-ppce500/qemu-ppce500.c b/board/freescale/qemu-ppce500/qemu-ppce500.c > index a0fca0d..6cb5692 100644 > --- a/board/freescale/qemu-ppce500/qemu-ppce500.c > +++ b/board/freescale/qemu-ppce500/qemu-ppce500.c > @@ -81,7 +81,7 @@ static int pci_map_region(void *fdt, int pci_node, int range_id, > ulong map_addr; > int r; > > - r = fdt_read_range(fdt, pci_node, 0, NULL, &addr, &size); > + r = fdt_read_range(fdt, pci_node, range_id, NULL, &addr, &size); > if (r) > return r; > >
On Mon, Dec 21, 2015 at 01:19:59AM -0800, Miao Yan wrote: > In pci_map_region(), pass 'range_id' to fdt_read_range(), > otherwise the same address will be mapped again in other > calls to pci_map_region() > > Signed-off-by: Miao Yan <yammiaobest@gmail.com> > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> > Reviewed-by: Alexander Graf <agraf@suse.de> Applied to u-boot/master, thanks!
diff --git a/board/freescale/qemu-ppce500/qemu-ppce500.c b/board/freescale/qemu-ppce500/qemu-ppce500.c index a0fca0d..6cb5692 100644 --- a/board/freescale/qemu-ppce500/qemu-ppce500.c +++ b/board/freescale/qemu-ppce500/qemu-ppce500.c @@ -81,7 +81,7 @@ static int pci_map_region(void *fdt, int pci_node, int range_id, ulong map_addr; int r; - r = fdt_read_range(fdt, pci_node, 0, NULL, &addr, &size); + r = fdt_read_range(fdt, pci_node, range_id, NULL, &addr, &size); if (r) return r;
In pci_map_region(), pass 'range_id' to fdt_read_range(), otherwise the same address will be mapped again in other calls to pci_map_region() Signed-off-by: Miao Yan <yammiaobest@gmail.com> --- board/freescale/qemu-ppce500/qemu-ppce500.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)