diff mbox

[U-Boot,v2,01/13] debug_uart: restore ns16550 as default

Message ID 1447854299-23680-2-git-send-email-thomas@wytron.com.tw
State Superseded
Delegated to: Tom Rini
Headers show

Commit Message

Thomas Chou Nov. 18, 2015, 1:44 p.m. UTC 
Since commit 220e8021af96 ("nios2: convert altera_jtag_uart to
driver model"), the default debug uart was changed. Most people
use ns16550 UART, so restore it as default.

Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
Reported-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Reported-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
Reviewed-by: Tom Rini <trini@konsulko.com>
---
 drivers/serial/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Bin Meng Nov. 18, 2015, 1:51 p.m. UTC | #1 
On Wed, Nov 18, 2015 at 9:44 PM, Thomas Chou <thomas@wytron.com.tw> wrote:
> Since commit 220e8021af96 ("nios2: convert altera_jtag_uart to
> driver model"), the default debug uart was changed. Most people
> use ns16550 UART, so restore it as default.
>
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> Reported-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> Reported-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
> Reviewed-by: Tom Rini <trini@konsulko.com>
> ---
>  drivers/serial/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
> index eba96f4..2a50771 100644
> --- a/drivers/serial/Kconfig
> +++ b/drivers/serial/Kconfig
> @@ -53,6 +53,7 @@ config DEBUG_UART
>  choice
>         prompt "Select which UART will provide the debug UART"
>         depends on DEBUG_UART
> +       default DEBUG_UART_NS16550
>
>  config DEBUG_UART_ALTERA_JTAGUART
>         bool "Altera JTAG UART"
> --

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Heiko Schocher Nov. 19, 2015, 6:38 a.m. UTC | #2 
Hello Thomas,

Am 18.11.2015 um 14:44 schrieb Thomas Chou:
> Since commit 220e8021af96 ("nios2: convert altera_jtag_uart to
> driver model"), the default debug uart was changed. Most people
> use ns16550 UART, so restore it as default.
>
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> Reported-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> Reported-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
> Reviewed-by: Tom Rini <trini@konsulko.com>
> ---
>   drivers/serial/Kconfig | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
>
> diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
> index eba96f4..2a50771 100644
> --- a/drivers/serial/Kconfig
> +++ b/drivers/serial/Kconfig
> @@ -53,6 +53,7 @@ config DEBUG_UART
>   choice
>   	prompt "Select which UART will provide the debug UART"
>   	depends on DEBUG_UART
> +	default DEBUG_UART_NS16550
>
>   config DEBUG_UART_ALTERA_JTAGUART
>   	bool "Altera JTAG UART"
>
diff mbox

Patch

diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
index eba96f4..2a50771 100644
--- a/drivers/serial/Kconfig
+++ b/drivers/serial/Kconfig
@@ -53,6 +53,7 @@  config DEBUG_UART
 choice
 	prompt "Select which UART will provide the debug UART"
 	depends on DEBUG_UART
+	default DEBUG_UART_NS16550
 
 config DEBUG_UART_ALTERA_JTAGUART
 	bool "Altera JTAG UART"