| Message ID | 1446732171-7439-3-git-send-email-bmeng.cn@gmail.com |
|---|---|
| State | Superseded |
| Delegated to: | Simon Glass |
| Headers | show |
Hi Bin, On 2015年11月05日 22:02, Bin Meng wrote: > Every timer device needs to have a valid clock frequency and it > can be specified in the device tree. Use pre_probe() to get this > in the timer uclass driver. > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com> > --- > > drivers/timer/timer-uclass.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/timer/timer-uclass.c b/drivers/timer/timer-uclass.c > index 82c6897..0218591 100644 > --- a/drivers/timer/timer-uclass.c > +++ b/drivers/timer/timer-uclass.c > @@ -9,6 +9,8 @@ > #include <errno.h> > #include <timer.h> > > +DECLARE_GLOBAL_DATA_PTR; > + > /* > * Implement a timer uclass to work with lib/time.c. The timer is usually > * a 32 bits free-running up counter. The get_rate() method is used to get > @@ -35,8 +37,19 @@ unsigned long timer_get_rate(struct udevice *dev) > return uc_priv->clock_rate; > } > > +static int timer_pre_probe(struct udevice *dev) > +{ > + struct timer_dev_priv *uc_priv = dev_get_uclass_priv(dev); > + > + uc_priv->clock_rate = fdtdec_get_int(gd->fdt_blob, dev->of_offset, > + "clock-frequency", 0); > + > + return 0; > +} > + > UCLASS_DRIVER(timer) = { > .id = UCLASS_TIMER, > .name = "timer", > + .pre_probe = timer_pre_probe, > .per_device_auto_alloc_size = sizeof(struct timer_dev_priv), > }; > Acked-by: Thomas Chou <thomas@wytron.com.tw>
On 6 November 2015 at 00:00, Thomas Chou <thomas@wytron.com.tw> wrote: > Hi Bin, > > > On 2015年11月05日 22:02, Bin Meng wrote: >> >> Every timer device needs to have a valid clock frequency and it >> can be specified in the device tree. Use pre_probe() to get this >> in the timer uclass driver. >> >> Signed-off-by: Bin Meng <bmeng.cn@gmail.com> >> --- >> >> drivers/timer/timer-uclass.c | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) Acked-by: Simon Glass <sjg@chromium.org>
diff --git a/drivers/timer/timer-uclass.c b/drivers/timer/timer-uclass.c index 82c6897..0218591 100644 --- a/drivers/timer/timer-uclass.c +++ b/drivers/timer/timer-uclass.c @@ -9,6 +9,8 @@ #include <errno.h> #include <timer.h> +DECLARE_GLOBAL_DATA_PTR; + /* * Implement a timer uclass to work with lib/time.c. The timer is usually * a 32 bits free-running up counter. The get_rate() method is used to get @@ -35,8 +37,19 @@ unsigned long timer_get_rate(struct udevice *dev) return uc_priv->clock_rate; } +static int timer_pre_probe(struct udevice *dev) +{ + struct timer_dev_priv *uc_priv = dev_get_uclass_priv(dev); + + uc_priv->clock_rate = fdtdec_get_int(gd->fdt_blob, dev->of_offset, + "clock-frequency", 0); + + return 0; +} + UCLASS_DRIVER(timer) = { .id = UCLASS_TIMER, .name = "timer", + .pre_probe = timer_pre_probe, .per_device_auto_alloc_size = sizeof(struct timer_dev_priv), };
Every timer device needs to have a valid clock frequency and it can be specified in the device tree. Use pre_probe() to get this in the timer uclass driver. Signed-off-by: Bin Meng <bmeng.cn@gmail.com> --- drivers/timer/timer-uclass.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)