| Message ID | 1445340745-1000-5-git-send-email-viktorin@rehivetech.com |
|---|---|
| State | Changes Requested |
| Headers | show |
Hello, On Tue, 20 Oct 2015 13:32:22 +0200, Jan Viktorin wrote: > As we've integrated the mkpimage, we just leave some notes > about other available tools and give an advice how to enable > this feature in Buildroot. > > Signed-off-by: Jan Viktorin <viktorin@rehivetech.com> > --- > board/altera/readme.txt | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git a/board/altera/readme.txt b/board/altera/readme.txt > index ddd9e03..fdd7316 100644 > --- a/board/altera/readme.txt > +++ b/board/altera/readme.txt > @@ -75,21 +75,23 @@ After building, you should obtain this tree: > ├── socfpga.dtb > ├── u-boot.img > ├── u-boot-spl.bin > + ├── u-boot-spl.bin.crc > └── uImage > > > Signing the Preloader > --------------------- > > -*** BEWARE **** > -The u-boot-spl.bin must be signed using the Altera's tool "mkpimage". > -This tool comes as a part of the Altera development environnment (SoC EDS). > -A fork of this tool have been done by Maxime Hadjinlian and can be found here : > -https://github.com/maximeh/mkpimage > +The u-boot-spl.bin needs a checksum computed by the Altera's tool "mkpimage". > +This tool comes as a part of the Altera development environnment (SoC EDS), > +as a standalone tool https://github.com/maximeh/mkpimage and as a part of the > +Barebox project. The boards do not boot without the checksum. > > -Remember that without signing the u-boot-spl.bin, the board will not boot !!! > +The Buildroot integrates the mkpimage and you can find it in the configuration. > +If you check: "Bootloaders/U-Boot/CRC SPL image for SoC FPGA" the build system > +calls mkpimage on the SPL for you automatically. > > - $ mkpimage u-boot-spl.bin -o u-boot-spl-signed.bin > + $ mkpimage u-boot-spl.bin -o u-boot-spl.bin.crc This is the wrong change. Instead, you should just modify the two Altera defconfigs we have to use the new feature, and remove all that text since the final bootloader image is now automatically generated by Buildroot. You can leave a note like "The final U-Boot image with the Altera required CRC is automatically generated by Buildroot using mkpimage", but all the rest is useless once the defconfigs are changed. I'll mark this patch as Changes Requested in our patch tracking system. Thanks! Thomas
diff --git a/board/altera/readme.txt b/board/altera/readme.txt index ddd9e03..fdd7316 100644 --- a/board/altera/readme.txt +++ b/board/altera/readme.txt @@ -75,21 +75,23 @@ After building, you should obtain this tree: ├── socfpga.dtb ├── u-boot.img ├── u-boot-spl.bin + ├── u-boot-spl.bin.crc └── uImage Signing the Preloader --------------------- -*** BEWARE **** -The u-boot-spl.bin must be signed using the Altera's tool "mkpimage". -This tool comes as a part of the Altera development environnment (SoC EDS). -A fork of this tool have been done by Maxime Hadjinlian and can be found here : -https://github.com/maximeh/mkpimage +The u-boot-spl.bin needs a checksum computed by the Altera's tool "mkpimage". +This tool comes as a part of the Altera development environnment (SoC EDS), +as a standalone tool https://github.com/maximeh/mkpimage and as a part of the +Barebox project. The boards do not boot without the checksum. -Remember that without signing the u-boot-spl.bin, the board will not boot !!! +The Buildroot integrates the mkpimage and you can find it in the configuration. +If you check: "Bootloaders/U-Boot/CRC SPL image for SoC FPGA" the build system +calls mkpimage on the SPL for you automatically. - $ mkpimage u-boot-spl.bin -o u-boot-spl-signed.bin + $ mkpimage u-boot-spl.bin -o u-boot-spl.bin.crc Prepare your SDcard ===================
As we've integrated the mkpimage, we just leave some notes about other available tools and give an advice how to enable this feature in Buildroot. Signed-off-by: Jan Viktorin <viktorin@rehivetech.com> --- board/altera/readme.txt | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-)