diff mbox

[1/3] package/kodi-pvr-argustv: add jsoncpp reverse dependency

Message ID 1443730342-12383-1-git-send-email-bernd.kuhls@t-online.de
State Superseded
Headers show

Commit Message

Bernd Kuhls Oct. 1, 2015, 8:12 p.m. UTC
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/kodi-pvr-argustv/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Baruch Siach Oct. 1, 2015, 8:29 p.m. UTC | #1
Hi Bernd,

On Thu, Oct 01, 2015 at 10:12:20PM +0200, Bernd Kuhls wrote:
> diff --git a/package/kodi-pvr-argustv/Config.in 
> b/package/kodi-pvr-argustv/Config.in
> index 698ff46..ad27c38 100644
> --- a/package/kodi-pvr-argustv/Config.in
> +++ b/package/kodi-pvr-argustv/Config.in
> @@ -1,7 +1,11 @@
>  config BR2_PACKAGE_KODI_PVR_ARGUSTV
>  	bool "kodi-pvr-argustv"
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # jsoncpp

Why is that needed? Same for other patches in this series.

baruch
Bernd Kuhls Oct. 1, 2015, 8:49 p.m. UTC | #2
Am Thu, 01 Oct 2015 23:29:35 +0300 schrieb Baruch Siach:

>>  config BR2_PACKAGE_KODI_PVR_ARGUSTV
>>  	bool "kodi-pvr-argustv"
>> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # jsoncpp
> 
> Why is that needed? Same for other patches in this series.

Hi Baruch,

the three pvr packages depend on jsoncpp, this is reflected in the .mk 
files and also in Config.in with the exception of kodi-pvr-argustv, where 
that select-line was missing, so I sent v2:
http://patchwork.ozlabs.org/patch/525299/

All packages lacked the rev dependency to gcc-4.7.

Regards, Bernd
diff mbox

Patch

diff --git a/package/kodi-pvr-argustv/Config.in b/package/kodi-pvr-argustv/Config.in
index 698ff46..ad27c38 100644
--- a/package/kodi-pvr-argustv/Config.in
+++ b/package/kodi-pvr-argustv/Config.in
@@ -1,7 +1,11 @@ 
 config BR2_PACKAGE_KODI_PVR_ARGUSTV
 	bool "kodi-pvr-argustv"
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # jsoncpp
 	select BR2_PACKAGE_KODI_PLATFORM
 	help
 	  Kodi's ARGUS TV client addon
 
 	  https://github.com/kodi-pvr/pvr.argustv
+
+comment "kodi-pvr-argustv needs a toolchain w/ C++, gcc >= 4.7"
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7