| Message ID | c0676cbc3b883de88e98c9ba28d8023f17cb5e88.1443531503.git.baruch@tkos.co.il |
|---|---|
| State | Accepted |
| Headers | show |
Baruch, On Tue, 29 Sep 2015 15:58:22 +0300, Baruch Siach wrote: > diff --git a/package/libbluray/libbluray.mk b/package/libbluray/libbluray.mk > index e10f7dbc8c73..f6a501a1083f 100644 > --- a/package/libbluray/libbluray.mk > +++ b/package/libbluray/libbluray.mk > @@ -24,6 +24,12 @@ else > LIBBLURAY_CONF_OPTS += --without-freetype > endif > > +ifeq ($(BR2_PACKAGE_FONTCONFIG),y) > +LIBBLURAY_DEPENDENCIES += fontconfig > +else > +LIBBLURAY_CONF_OPTS += --without-fontconfig > +endif I would prefer to have an explicit --with-fontconfig when BR2_PACKAGE_FONTCONFIG=y. I know it's not the case for the other dependencies already handled by libbluray.mk, so I've applied your patch as is, and my comment can be fixed for all optional dependencies of libbluray in a separate patch. Thanks! Thomas
Hi Thomas, On Tue, Sep 29, 2015 at 07:41:54PM +0200, Thomas Petazzoni wrote: > On Tue, 29 Sep 2015 15:58:22 +0300, Baruch Siach wrote: > > > diff --git a/package/libbluray/libbluray.mk b/package/libbluray/libbluray.mk > > index e10f7dbc8c73..f6a501a1083f 100644 > > --- a/package/libbluray/libbluray.mk > > +++ b/package/libbluray/libbluray.mk > > @@ -24,6 +24,12 @@ else > > LIBBLURAY_CONF_OPTS += --without-freetype > > endif > > > > +ifeq ($(BR2_PACKAGE_FONTCONFIG),y) > > +LIBBLURAY_DEPENDENCIES += fontconfig > > +else > > +LIBBLURAY_CONF_OPTS += --without-fontconfig > > +endif > > I would prefer to have an explicit --with-fontconfig when > BR2_PACKAGE_FONTCONFIG=y. I know it's not the case for the other > dependencies already handled by libbluray.mk, so I've applied your > patch as is, and my comment can be fixed for all optional dependencies > of libbluray in a separate patch. Just posted a patch for that. Thanks, baruch
diff --git a/package/libbluray/libbluray.mk b/package/libbluray/libbluray.mk index e10f7dbc8c73..f6a501a1083f 100644 --- a/package/libbluray/libbluray.mk +++ b/package/libbluray/libbluray.mk @@ -24,6 +24,12 @@ else LIBBLURAY_CONF_OPTS += --without-freetype endif +ifeq ($(BR2_PACKAGE_FONTCONFIG),y) +LIBBLURAY_DEPENDENCIES += fontconfig +else +LIBBLURAY_CONF_OPTS += --without-fontconfig +endif + ifeq ($(BR2_PACKAGE_LIBXML2),y) LIBBLURAY_DEPENDENCIES += libxml2 else
Fixes: http://autobuild.buildroot.net/results/dbf/dbfbf09f48e7ec09be34a3a40d3c859b74379eaf/ http://autobuild.buildroot.net/results/3fb/3fb9c077d4fe772774f53c7611b4dcbaad361312/ http://autobuild.buildroot.net/results/f9c/f9c1f3cf8bfa9eeacb7719459c22bdf7dea26ddb/ and more. Cc: Bernd Kuhls <bernd.kuhls@t-online.de> Signed-off-by: Baruch Siach <baruch@tkos.co.il> --- package/libbluray/libbluray.mk | 6 ++++++ 1 file changed, 6 insertions(+)