diff mbox

[1/1] target-finalize: remove extra /usr/libexec/*.a and *.la files

Message ID 1442323626-31294-1-git-send-email-Herve.CODINA@celad.com
State Accepted
Headers show

Commit Message

Hervé CODINA Sept. 15, 2015, 1:27 p.m. UTC
Some packages, sudo for instance, install .la files in $(TARGET_DIR)/usr/libexec.
These files are not needed on target.

This patch simply removes *.a and *.la files from $(TARGET_DIR)/usr/libexec if it exists

Signed-off-by: Herve Codina <Herve.CODINA@celad.com>
---
 Makefile |    3 +++
 1 file changed, 3 insertions(+)

Comments

Thomas Petazzoni Sept. 19, 2015, 1:06 p.m. UTC | #1
Herve,

On Tue, 15 Sep 2015 15:27:06 +0200, Herve Codina wrote:
> Some packages, sudo for instance, install .la files in $(TARGET_DIR)/usr/libexec.
> These files are not needed on target.
> 
> This patch simply removes *.a and *.la files from $(TARGET_DIR)/usr/libexec if it exists

I initially hesitated a bit first, because normally, plugins should be
installed in /usr/lib/<package>/. This can be done with
--with-plugindir, which moves a certain number of files installed by
default in /usr/libexec, but there are still a few libraries here
nonetheless. So your approach seems better.

> @@ -565,6 +565,9 @@ target-finalize: $(PACKAGES)
>  	find $(TARGET_DIR)/usr/{lib,share}/ -name '*.cmake' -print0 | xargs -0 rm -f
>  	find $(TARGET_DIR)/lib \( -name '*.a' -o -name '*.la' \) -print0 | xargs -0 rm -f
>  	find $(TARGET_DIR)/usr/lib \( -name '*.a' -o -name '*.la' \) -print0 | xargs -0 rm -f
> +	if test -d $(TARGET_DIR)/usr/libexec; then \
> +		find $(TARGET_DIR)/usr/libexec \( -name '*.a' -o -name '*.la' \) -print0 | \
> +		xargs -0 rm -f; fi

I've simplified that into a single "find" invocation for lib/, usr/lib
and usr/libexec.

See
http://git.buildroot.net/buildroot/commit/?id=87f3edecc65975085982515f3618c81bcfd9c023

Best regards,

Thomas
Hervé CODINA Sept. 21, 2015, 7:13 a.m. UTC | #2
Hi Thomas,

> I've simplified that into a single "find" invocation for lib/, usr/lib
> and usr/libexec.
> 
> See
> http://git.buildroot.net/buildroot/commit/?id=87f3edecc65975085982515f3618c81bcfd9c023
Ok for me.

Best regards,
Herve
diff mbox

Patch

diff --git a/Makefile b/Makefile
index 23e2ee6..9bf5fbc 100644
--- a/Makefile
+++ b/Makefile
@@ -565,6 +565,9 @@  target-finalize: $(PACKAGES)
 	find $(TARGET_DIR)/usr/{lib,share}/ -name '*.cmake' -print0 | xargs -0 rm -f
 	find $(TARGET_DIR)/lib \( -name '*.a' -o -name '*.la' \) -print0 | xargs -0 rm -f
 	find $(TARGET_DIR)/usr/lib \( -name '*.a' -o -name '*.la' \) -print0 | xargs -0 rm -f
+	if test -d $(TARGET_DIR)/usr/libexec; then \
+		find $(TARGET_DIR)/usr/libexec \( -name '*.a' -o -name '*.la' \) -print0 | \
+		xargs -0 rm -f; fi
 ifneq ($(BR2_PACKAGE_GDB),y)
 	rm -rf $(TARGET_DIR)/usr/share/gdb
 endif