diff mbox

[v2] zyre: fix static builds

Message ID 1440408666-62387-1-git-send-email-Vincent.Riera@imgtec.com
State Rejected
Headers show

Commit Message

Vicente Olivert Riera Aug. 24, 2015, 9:31 a.m. UTC
zyre package fails to build statically, so we pass the needed libs
directly in order to fix this problem.

Fixes:

  http://autobuild.buildroot.net/results/0ab/0ab4c6a4bb4942d51e7712073d4731d81ecb5251/

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
Changes v1 -> v2: add "Fixes" URL.

 package/zyre/zyre.mk |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

Comments

Thomas Petazzoni Aug. 26, 2015, 7:16 a.m. UTC | #1
Vicente,

On Mon, 24 Aug 2015 10:31:06 +0100, Vicente Olivert Riera wrote:
> zyre package fails to build statically, so we pass the needed libs
> directly in order to fix this problem.
> 
> Fixes:
> 
>   http://autobuild.buildroot.net/results/0ab/0ab4c6a4bb4942d51e7712073d4731d81ecb5251/
> 
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> Changes v1 -> v2: add "Fixes" URL.

I've committed a different fix, which consists in bumping the version
of zyre. In the latest (unreleased) version of Zyre, pkg-config is used
to find zmq and czmq, which fixes the static linking scenario.

I've therefore marked your patch as Rejected in patchwork.

Thanks!

Thomas
diff mbox

Patch

diff --git a/package/zyre/zyre.mk b/package/zyre/zyre.mk
index 661dddc..87ed427 100644
--- a/package/zyre/zyre.mk
+++ b/package/zyre/zyre.mk
@@ -12,6 +12,10 @@  ZYRE_INSTALL_STAGING = YES
 ZYRE_DEPENDENCIES = czmq zeromq
 ZYRE_AUTORECONF = YES
 
+ifeq ($(BR2_STATIC_LIBS),y)
+ZYRE_CONF_ENV += LIBS="-lzmq -lstdc++ -lczmq -pthread"
+endif
+
 define ZYRE_CREATE_CONFIG_DIR
 	mkdir -p $(@D)/config
 endef