| Message ID | 1439431779-16857-5-git-send-email-sjg@chromium.org |
|---|---|
| State | Superseded |
| Delegated to: | Simon Glass |
| Headers | show |
Hi Simon, On Thu, Aug 13, 2015 at 10:09 AM, Simon Glass <sjg@chromium.org> wrote: > These functions are defined by macros so do not show up with grep. Add > a comment to help. > > Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> One issue below: > --- > > include/pci.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/pci.h b/include/pci.h > index 488ff44..68df5cb 100644 > --- a/include/pci.h > +++ b/include/pci.h > @@ -653,6 +653,7 @@ extern pci_addr_t pci_hose_phys_to_bus(struct pci_controller* hose, > #define pci_io_to_virt(dev, addr, len, map_flags) \ > pci_bus_to_virt((dev), (addr), PCI_REGION_IO, (len), (map_flags)) > > +/* For driver model these are defined in micros in pci_compat.c */ typo: micros > extern int pci_hose_read_config_byte(struct pci_controller *hose, > pci_dev_t dev, int where, u8 *val); > extern int pci_hose_read_config_word(struct pci_controller *hose, > -- Regards, Bin
diff --git a/include/pci.h b/include/pci.h index 488ff44..68df5cb 100644 --- a/include/pci.h +++ b/include/pci.h @@ -653,6 +653,7 @@ extern pci_addr_t pci_hose_phys_to_bus(struct pci_controller* hose, #define pci_io_to_virt(dev, addr, len, map_flags) \ pci_bus_to_virt((dev), (addr), PCI_REGION_IO, (len), (map_flags)) +/* For driver model these are defined in micros in pci_compat.c */ extern int pci_hose_read_config_byte(struct pci_controller *hose, pci_dev_t dev, int where, u8 *val); extern int pci_hose_read_config_word(struct pci_controller *hose,
These functions are defined by macros so do not show up with grep. Add a comment to help. Signed-off-by: Simon Glass <sjg@chromium.org> --- include/pci.h | 1 + 1 file changed, 1 insertion(+)