diff mbox

[1/4] aiccu: remove redundant --static flag to pkg-config

Message ID 1437937112-13269-1-git-send-email-patrickdepinguin@gmail.com
State Accepted
Headers show

Commit Message

Thomas De Schampheleire July 26, 2015, 6:58 p.m. UTC 
From: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

The pkg-config tool is automatically passing --static when BR2_STATIC_LIBS
is set (see package/pkgconf/pkgconf.mk), so no need to pass it explicitly
from package .mk files.

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
---
 package/aiccu/aiccu.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yann E. MORIN July 26, 2015, 8:08 p.m. UTC | #1 
Thomas, All,

On 2015-07-26 20:58 +0200, Thomas De Schampheleire spake thusly:
> From: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
> 
> The pkg-config tool is automatically passing --static when BR2_STATIC_LIBS
> is set (see package/pkgconf/pkgconf.mk), so no need to pass it explicitly
> from package .mk files.
> 
> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/aiccu/aiccu.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/aiccu/aiccu.mk b/package/aiccu/aiccu.mk
> index fc328fd..60d65dd 100644
> --- a/package/aiccu/aiccu.mk
> +++ b/package/aiccu/aiccu.mk
> @@ -16,7 +16,7 @@ AICCU_LFDLAGS = $(TARGET_LDFLAGS)
>  # aiccu forgets to link with gnutls' dependencies breaking the build when
>  # linking statically
>  ifeq ($(BR2_STATIC_LIBS),y)
> -AICCU_LDFLAGS += `$(PKG_CONFIG_HOST_BINARY) --static --libs gnutls`
> +AICCU_LDFLAGS += `$(PKG_CONFIG_HOST_BINARY) --libs gnutls`
>  endif
>  
>  # dummy RPM_OPT_FLAGS to disable stripping
> -- 
> 1.8.5.1
>
Thomas Petazzoni July 26, 2015, 9:46 p.m. UTC | #2 
Dear Thomas De Schampheleire,

On Sun, 26 Jul 2015 20:58:29 +0200, Thomas De Schampheleire wrote:
> From: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
> 
> The pkg-config tool is automatically passing --static when BR2_STATIC_LIBS
> is set (see package/pkgconf/pkgconf.mk), so no need to pass it explicitly
> from package .mk files.
> 
> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
> ---
>  package/aiccu/aiccu.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

All four patches applied, thanks. Thanks also to Yann for the review,
and the discussion on IRC leading to those clean up patches.

Thanks!

Thomas
diff mbox

Patch

diff --git a/package/aiccu/aiccu.mk b/package/aiccu/aiccu.mk
index fc328fd..60d65dd 100644
--- a/package/aiccu/aiccu.mk
+++ b/package/aiccu/aiccu.mk
@@ -16,7 +16,7 @@  AICCU_LFDLAGS = $(TARGET_LDFLAGS)
 # aiccu forgets to link with gnutls' dependencies breaking the build when
 # linking statically
 ifeq ($(BR2_STATIC_LIBS),y)
-AICCU_LDFLAGS += `$(PKG_CONFIG_HOST_BINARY) --static --libs gnutls`
+AICCU_LDFLAGS += `$(PKG_CONFIG_HOST_BINARY) --libs gnutls`
 endif
 
 # dummy RPM_OPT_FLAGS to disable stripping