diff mbox

[V2] c-icap: fix config script by adding $(STAGING_DIR) prefix to link path. It fixes c-icap-modules build.

Message ID 1437641147-6894-1-git-send-email-guillaume.gardet@oliseo.fr
State Accepted
Headers show

Commit Message

Guillaume GARDET July 23, 2015, 8:45 a.m. UTC 
Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Guillaume GARDET <guillaume.gardet@oliseo.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

---
 package/c-icap/c-icap.mk | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Petazzoni July 23, 2015, 9:11 p.m. UTC | #1 
Dear Guillaume GARDET,

On Thu, 23 Jul 2015 10:45:47 +0200, Guillaume GARDET wrote:
> Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Guillaume GARDET <guillaume.gardet@oliseo.fr>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

I applied, but quite a few things were still wrong with the patch:

 * The commit title is too long. It should be less than 80 characters.
   The commit title should only be a summary of the commit log itself.

 * The commit title is wrong: you're no longer adding $(STAGING_DIR) to
   the link path

 * The commit log was missing a reference to the autobuilder failure
   that this patch is fixing.

I've fixed those problems and applied. See:

  http://git.buildroot.net/buildroot/commit/?id=6c73215493335f1ede26cad2d3898ef543d871d6

Thanks,

Thomas
Guillaume GARDET July 24, 2015, 2:04 p.m. UTC | #2 
Le 23/07/2015 23:11, Thomas Petazzoni a écrit :
> Dear Guillaume GARDET,
>
> On Thu, 23 Jul 2015 10:45:47 +0200, Guillaume GARDET wrote:
>> Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>> Signed-off-by: Guillaume GARDET <guillaume.gardet@oliseo.fr>
>> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> I applied, but quite a few things were still wrong with the patch:
>
>   * The commit title is too long. It should be less than 80 characters.
>     The commit title should only be a summary of the commit log itself.
>
>   * The commit title is wrong: you're no longer adding $(STAGING_DIR) to
>     the link path
>
>   * The commit log was missing a reference to the autobuilder failure
>     that this patch is fixing.
>
> I've fixed those problems and applied. See:
>
>    http://git.buildroot.net/buildroot/commit/?id=6c73215493335f1ede26cad2d3898ef543d871d6

Thanks.
I copy/paste V1 to V2 too quickly. Sorry.


Guillaume

>
> Thanks,
>
> Thomas
diff mbox

Patch

diff --git a/package/c-icap/c-icap.mk b/package/c-icap/c-icap.mk
index 0f42b6c..0e27cc4 100644
--- a/package/c-icap/c-icap.mk
+++ b/package/c-icap/c-icap.mk
@@ -57,6 +57,7 @@  define C_ICAP_TUNE_INSTALLATION
 		$(STAGING_DIR)/usr/bin/{c-icap,c-icap-libicapapi}-config
 	$(SED) 's%INCDIR2=.*%INCDIR2=$(STAGING_DIR)/usr/include/c_icap%' \
 		$(STAGING_DIR)/usr/bin/{c-icap,c-icap-libicapapi}-config
+	$(SED) 's%-L$$LIBDIR %%' $(STAGING_DIR)/usr/bin/c-icap-libicapapi-config
 endef
 
 C_ICAP_POST_INSTALL_TARGET_HOOKS += C_ICAP_TUNE_INSTALLATION