diff mbox

[U-Boot,27/48] x86: dts: Add a device tree file for EFI

Message ID 1437580180-6405-28-git-send-email-sjg@chromium.org
State Superseded
Delegated to: Simon Glass
Headers show

Commit Message

Simon Glass July 22, 2015, 3:49 p.m. UTC 
This contains just enough to bring up the serial UART.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 arch/x86/dts/Makefile |  1 +
 arch/x86/dts/efi.dts  | 22 ++++++++++++++++++++++
 2 files changed, 23 insertions(+)
 create mode 100644 arch/x86/dts/efi.dts

Comments

Bin Meng July 23, 2015, 9:52 a.m. UTC | #1 
Hi Simon,

On Wed, Jul 22, 2015 at 11:49 PM, Simon Glass <sjg@chromium.org> wrote:
> This contains just enough to bring up the serial UART.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>  arch/x86/dts/Makefile |  1 +
>  arch/x86/dts/efi.dts  | 22 ++++++++++++++++++++++
>  2 files changed, 23 insertions(+)
>  create mode 100644 arch/x86/dts/efi.dts
>
> diff --git a/arch/x86/dts/Makefile b/arch/x86/dts/Makefile
> index f86514c..53d0a04 100644
> --- a/arch/x86/dts/Makefile
> +++ b/arch/x86/dts/Makefile
> @@ -1,6 +1,7 @@
>  dtb-y += chromebook_link.dtb \
>         chromebox_panther.dtb \
>         crownbay.dtb \
> +       efi.dtb \
>         galileo.dtb \
>         minnowmax.dtb \
>         qemu-x86_i440fx.dtb \
> diff --git a/arch/x86/dts/efi.dts b/arch/x86/dts/efi.dts
> new file mode 100644
> index 0000000..a6a5d38
> --- /dev/null
> +++ b/arch/x86/dts/efi.dts
> @@ -0,0 +1,22 @@
> +/*
> ++ * Copyright (c) 2015 Google, Inc

Please remove the leading +

> + *
> + * SPDX-License-Identifier:    GPL-2.0+
> + */
> +
> +/dts-v1/;
> +
> +/include/ "skeleton.dtsi"
> +
> +/ {
> +       model = "EFI";
> +       compatible = "efi,payload";

Shouldn't it be "efi,app"?

> +
> +       chosen {
> +               stdout-path = &serial;
> +       };
> +
> +       serial: serial {
> +               compatible = "efi,uart";
> +       };
> +};
> --

Regards,
Bin
diff mbox

Patch

diff --git a/arch/x86/dts/Makefile b/arch/x86/dts/Makefile
index f86514c..53d0a04 100644
--- a/arch/x86/dts/Makefile
+++ b/arch/x86/dts/Makefile
@@ -1,6 +1,7 @@ 
 dtb-y += chromebook_link.dtb \
 	chromebox_panther.dtb \
 	crownbay.dtb \
+	efi.dtb \
 	galileo.dtb \
 	minnowmax.dtb \
 	qemu-x86_i440fx.dtb \
diff --git a/arch/x86/dts/efi.dts b/arch/x86/dts/efi.dts
new file mode 100644
index 0000000..a6a5d38
--- /dev/null
+++ b/arch/x86/dts/efi.dts
@@ -0,0 +1,22 @@ 
+/*
++ * Copyright (c) 2015 Google, Inc
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+
+/dts-v1/;
+
+/include/ "skeleton.dtsi"
+
+/ {
+	model = "EFI";
+	compatible = "efi,payload";
+
+	chosen {
+		stdout-path = &serial;
+	};
+
+	serial: serial {
+		compatible = "efi,uart";
+	};
+};