diff mbox

[U-Boot,21/48] efi: Drop CONFIG_SYS_TEXT_BASE for EFI

Message ID 1437580180-6405-22-git-send-email-sjg@chromium.org
State Superseded
Delegated to: Simon Glass
Headers show

Commit Message

Simon Glass July 22, 2015, 3:49 p.m. UTC 
From: Ben Stoltz <stoltz@google.com>

When U-Boot runs as an EFI application is does not have a definition of
CONFIG_SYS_TEXT_BASE. U-Boot is a relocatable application and the relocation
is done by EFI. U-Boot can be loaded at any address.

Ensure that this CONFIG option is not set in this case.

Signed-off-by: Ben Stoltz <stoltz@google.com>
Signed-off-by: Simon Glass <sjg@chromium.org>
---

 Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Bin Meng July 23, 2015, 8:33 a.m. UTC | #1 
Hi Simon,

On Wed, Jul 22, 2015 at 11:49 PM, Simon Glass <sjg@chromium.org> wrote:
> From: Ben Stoltz <stoltz@google.com>
>
> When U-Boot runs as an EFI application is does not have a definition of
> CONFIG_SYS_TEXT_BASE. U-Boot is a relocatable application and the relocation
> is done by EFI. U-Boot can be loaded at any address.
>
> Ensure that this CONFIG option is not set in this case.
>
> Signed-off-by: Ben Stoltz <stoltz@google.com>
> Signed-off-by: Simon Glass <sjg@chromium.org>

Except the name of ARCH_EFI per my previous comments:

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

> ---
>
>  Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Kconfig b/Kconfig
> index 15e15af..c1e7d22 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -179,6 +179,7 @@ config SYS_EXTRA_OPTIONS
>
>  config SYS_TEXT_BASE
>         depends on SPARC || ARC || X86 || ARCH_UNIPHIER
> +       depends on !ARCH_EFI
>         hex "Text Base"
>         help
>           TODO: Move CONFIG_SYS_TEXT_BASE for all the architecture
> --

Regards,
Bin
diff mbox

Patch

diff --git a/Kconfig b/Kconfig
index 15e15af..c1e7d22 100644
--- a/Kconfig
+++ b/Kconfig
@@ -179,6 +179,7 @@  config SYS_EXTRA_OPTIONS
 
 config SYS_TEXT_BASE
 	depends on SPARC || ARC || X86 || ARCH_UNIPHIER
+	depends on !ARCH_EFI
 	hex "Text Base"
 	help
 	  TODO: Move CONFIG_SYS_TEXT_BASE for all the architecture