| Message ID | 1437051754-24060-2-git-send-email-nicolas.cavallari@green-communications.fr |
|---|---|
| State | Superseded |
| Headers | show |
Hi Nicolas, On Thu, Jul 16, 2015 at 03:02:34PM +0200, Nicolas Cavallari wrote: > Hotspot 2.0 uses ANQP whose implementation needs offchannel/ > remain-on-channel capabilities from the driver, which only exist in the > nl80211 driver. Compiling would work, but the feature would not work. Your sign-off is missing. > package/wpa_supplicant/Config.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/wpa_supplicant/Config.in b/package/wpa_supplicant/Config.in > index 1824f95..c163bbc 100644 > --- a/package/wpa_supplicant/Config.in > +++ b/package/wpa_supplicant/Config.in > @@ -40,6 +40,7 @@ config BR2_PACKAGE_WPA_SUPPLICANT_EAP > > config BR2_PACKAGE_WPA_SUPPLICANT_HOTSPOT > bool "Enable HS20" > + depends on BR2_PACKAGE_WPA_SUPPLICANT_NL80211 Please add the BR2_PACKAGE_LIBNL dependency here as well. baruch
Dear Baruch Siach, On Fri, 17 Jul 2015 09:41:01 +0300, Baruch Siach wrote: > > package/wpa_supplicant/Config.in | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/package/wpa_supplicant/Config.in b/package/wpa_supplicant/Config.in > > index 1824f95..c163bbc 100644 > > --- a/package/wpa_supplicant/Config.in > > +++ b/package/wpa_supplicant/Config.in > > @@ -40,6 +40,7 @@ config BR2_PACKAGE_WPA_SUPPLICANT_EAP > > > > config BR2_PACKAGE_WPA_SUPPLICANT_HOTSPOT > > bool "Enable HS20" > > + depends on BR2_PACKAGE_WPA_SUPPLICANT_NL80211 > > Please add the BR2_PACKAGE_LIBNL dependency here as well. Not needed since it's a "depends on", so BR2_PACKAGE_WPA_SUPPLICANT_HOTSPOT will anyway only be visible if BR2_PACKAGE_WPA_SUPPLICANT_NL80211 is enabled, and if BR2_PACKAGE_WPA_SUPPLICANT_NL80211 is enabled, then it has selected BR2_PACKAGE_LIBNL. Am I missing something? Thomas
On 17/07/2015 09:45, Thomas Petazzoni wrote: > On Fri, 17 Jul 2015 09:41:01 +0300, Baruch Siach wrote: >>> config BR2_PACKAGE_WPA_SUPPLICANT_HOTSPOT >>> bool "Enable HS20" >>> + depends on BR2_PACKAGE_WPA_SUPPLICANT_NL80211 >> >> Please add the BR2_PACKAGE_LIBNL dependency here as well. > > Not needed since it's a "depends on", so > BR2_PACKAGE_WPA_SUPPLICANT_HOTSPOT will anyway only be visible if > BR2_PACKAGE_WPA_SUPPLICANT_NL80211 is enabled, and if > BR2_PACKAGE_WPA_SUPPLICANT_NL80211 is enabled, then it has selected > BR2_PACKAGE_LIBNL. > > Am I missing something? I was thinking the same thing.
Hi Thomas, On Fri, Jul 17, 2015 at 09:45:32AM +0200, Thomas Petazzoni wrote: > On Fri, 17 Jul 2015 09:41:01 +0300, Baruch Siach wrote: > > > package/wpa_supplicant/Config.in | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/package/wpa_supplicant/Config.in b/package/wpa_supplicant/Config.in > > > index 1824f95..c163bbc 100644 > > > --- a/package/wpa_supplicant/Config.in > > > +++ b/package/wpa_supplicant/Config.in > > > @@ -40,6 +40,7 @@ config BR2_PACKAGE_WPA_SUPPLICANT_EAP > > > > > > config BR2_PACKAGE_WPA_SUPPLICANT_HOTSPOT > > > bool "Enable HS20" > > > + depends on BR2_PACKAGE_WPA_SUPPLICANT_NL80211 > > > > Please add the BR2_PACKAGE_LIBNL dependency here as well. > > Not needed since it's a "depends on", so > BR2_PACKAGE_WPA_SUPPLICANT_HOTSPOT will anyway only be visible if > BR2_PACKAGE_WPA_SUPPLICANT_NL80211 is enabled, and if > BR2_PACKAGE_WPA_SUPPLICANT_NL80211 is enabled, then it has selected > BR2_PACKAGE_LIBNL. > > Am I missing something? Right. The dependency of hotspot on libnl is no apparent at all, though. IMO, having here select BR2_PACKAGE_WPA_SUPPLICANT_NL80211 depends on BR2_TOOLCHAIN_HAS_THREADS # libnl and maybe also a dependency comment, would be better. baruch
diff --git a/package/wpa_supplicant/Config.in b/package/wpa_supplicant/Config.in index 1824f95..c163bbc 100644 --- a/package/wpa_supplicant/Config.in +++ b/package/wpa_supplicant/Config.in @@ -40,6 +40,7 @@ config BR2_PACKAGE_WPA_SUPPLICANT_EAP config BR2_PACKAGE_WPA_SUPPLICANT_HOTSPOT bool "Enable HS20" + depends on BR2_PACKAGE_WPA_SUPPLICANT_NL80211 help Enable Hotspot 2.0 and IEEE 802.11u interworking functionality.