diff mbox

[U-Boot,03/11] x86: bios: Allow pci config read/write to host bridge in int1a_handler

Message ID BLU437-SMTP3420DA1C9B73DE211FB2C8BFA80@phx.gbl
State Superseded
Delegated to: Simon Glass
Headers show

Commit Message

Bin Meng July 1, 2015, 8:28 a.m. UTC 
From: Jian Luo <jian.luo4@boschrexroth.de>

We should allow pci config read/write to host bridge (b.d.f = 0.0.0)
in the int1a_handler() which is a valid pci device.

Signed-off-by: Jian Luo <jian.luo4@boschrexroth.de>
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 arch/x86/lib/bios_interrupts.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

Comments

Simon Glass July 1, 2015, 2:58 p.m. UTC | #1 
On 1 July 2015 at 02:28, Bin Meng <bmeng.cn@gmail.com> wrote:
> From: Jian Luo <jian.luo4@boschrexroth.de>
>
> We should allow pci config read/write to host bridge (b.d.f = 0.0.0)
> in the int1a_handler() which is a valid pci device.
>
> Signed-off-by: Jian Luo <jian.luo4@boschrexroth.de>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
>  arch/x86/lib/bios_interrupts.c | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)

Acked-by: Simon Glass <sjg@chromium.org>
diff mbox

Patch

diff --git a/arch/x86/lib/bios_interrupts.c b/arch/x86/lib/bios_interrupts.c
index 290990a..47d9f59 100644
--- a/arch/x86/lib/bios_interrupts.c
+++ b/arch/x86/lib/bios_interrupts.c
@@ -161,15 +161,7 @@  int int1a_handler(void)
 		bus = M.x86.R_EBX >> 8;
 		reg = M.x86.R_EDI;
 		dev = PCI_BDF(bus, devfn >> 3, devfn & 7);
-		if (!dev) {
-			debug("0x%x: BAD DEVICE bus %d devfn 0x%x\n", func,
-			      bus, devfn);
-			/* Or are we supposed to return PCIBIOS_NODEV? */
-			M.x86.R_EAX &= 0xffff00ff; /* Clear AH */
-			M.x86.R_EAX |= PCIBIOS_BADREG;
-			retval = 0;
-			return retval;
-		}
+
 		switch (func) {
 		case 0xb108: /* Read Config Byte */
 			byte = x86_pci_read_config8(dev, reg);