| Message ID | 1433831250-31968-2-git-send-email-rahul.bedarkar@imgtec.com |
|---|---|
| State | Superseded |
| Headers | show |
Dear Rahul Bedarkar, Thanks for this contribution. A few comments below. On Tue, 9 Jun 2015 11:57:29 +0530, Rahul Bedarkar wrote: > diff --git a/package/gflags/gflags.hash b/package/gflags/gflags.hash > new file mode 100644 > index 0000000..9c8b27a > --- /dev/null > +++ b/package/gflags/gflags.hash > @@ -0,0 +1,2 @@ > +# No hash for v2.1.2, comes from the github-helper: > +none xxx gflags-v2.1.2.tar.gz I believe in this case, we generally do not provide a hash file at all. Though maybe in the future we will want to have a hash file for *all* packages. Yann, what is our policy on this? > +GFLAGS_VERSION = v2.1.2 > +GFLAGS_SITE = $(call github,gflags,gflags,$(GFLAGS_VERSION)) > +GFLAGS_INSTALL_STAGING = YES > +GFLAGS_LICENSE = BSD-3c > +GFLAGS_LICENSE_FILES = COPYING.txt > + > +ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),n) This should be: ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),) Best regards, Thomas
Thomas, Rahul, All, On 2015-06-09 09:01 +0200, Thomas Petazzoni spake thusly: > On Tue, 9 Jun 2015 11:57:29 +0530, Rahul Bedarkar wrote: > > > diff --git a/package/gflags/gflags.hash b/package/gflags/gflags.hash > > new file mode 100644 > > index 0000000..9c8b27a > > --- /dev/null > > +++ b/package/gflags/gflags.hash > > @@ -0,0 +1,2 @@ > > +# No hash for v2.1.2, comes from the github-helper: > > +none xxx gflags-v2.1.2.tar.gz > > I believe in this case, we generally do not provide a hash file at all. > Though maybe in the future we will want to have a hash file for *all* > packages. Yann, what is our policy on this? Hmm. Ideally, I think we want a .hash file for all packages, so that can eventually be a hard error when one is missing. However, I can see that can be cumbersome to add a .hash file to just say 'talk to my hand, I have no hash'. Especially as we're not enforcing it so far... But I was planning on working on .hash sometime this summer to add all those missing at the time, so we have all .hash files for the lat release of the year. I'm pretty happy to see so many hashes being added in the meantime! ;-) So, to answer the specific question: I think that is good to have a none-hash file; and to top it off, it's nicely commented. :-) Regards, Yann E. MORIN. > > +GFLAGS_VERSION = v2.1.2 > > +GFLAGS_SITE = $(call github,gflags,gflags,$(GFLAGS_VERSION)) > > +GFLAGS_INSTALL_STAGING = YES > > +GFLAGS_LICENSE = BSD-3c > > +GFLAGS_LICENSE_FILES = COPYING.txt > > + > > +ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),n) > > This should be: > > ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),) > > Best regards, > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com
diff --git a/package/Config.in b/package/Config.in index e0c2e2a..84248c4 100644 --- a/package/Config.in +++ b/package/Config.in @@ -1013,6 +1013,7 @@ menu "Other" source "package/elfutils/Config.in" source "package/fftw/Config.in" source "package/flann/Config.in" + source "package/gflags/Config.in" source "package/glibmm/Config.in" source "package/glm/Config.in" source "package/gmp/Config.in" diff --git a/package/gflags/Config.in b/package/gflags/Config.in new file mode 100644 index 0000000..ed05944 --- /dev/null +++ b/package/gflags/Config.in @@ -0,0 +1,13 @@ +config BR2_PACKAGE_GFLAGS + bool "gflags" + depends on BR2_INSTALL_LIBSTDCPP + help + The gflags package contains a C++ library that implements + commandline flags processing. It includes built-in support for + standard types such as string and the ability to define flags + in the source file in which they are used. + + https://github.com/gflags/gflags + +comment "gflags needs a toolchain w/ C++" + depends on !BR2_INSTALL_LIBSTDCPP diff --git a/package/gflags/gflags.hash b/package/gflags/gflags.hash new file mode 100644 index 0000000..9c8b27a --- /dev/null +++ b/package/gflags/gflags.hash @@ -0,0 +1,2 @@ +# No hash for v2.1.2, comes from the github-helper: +none xxx gflags-v2.1.2.tar.gz diff --git a/package/gflags/gflags.mk b/package/gflags/gflags.mk new file mode 100644 index 0000000..a6029c7 --- /dev/null +++ b/package/gflags/gflags.mk @@ -0,0 +1,17 @@ +################################################################################ +# +# gflags +# +################################################################################ + +GFLAGS_VERSION = v2.1.2 +GFLAGS_SITE = $(call github,gflags,gflags,$(GFLAGS_VERSION)) +GFLAGS_INSTALL_STAGING = YES +GFLAGS_LICENSE = BSD-3c +GFLAGS_LICENSE_FILES = COPYING.txt + +ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),n) +GFLAGS_CONF_OPTS = -DBUILD_gflags_LIB=OFF +endif + +$(eval $(cmake-package))