Message ID | 1430562486-23625-1-git-send-email-romain.naour@openwide.fr |
---|---|
State | Accepted |
Headers | show |
On 02/05/15 12:28, Romain Naour wrote: > argp-standalone provide libargp.a and argp.h which are > never used in libpthsem. > > Signed-off-by: Romain Naour <romain.naour@openwide.fr> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Build-test with and without the _COMPAT option, and checked that there is no reference to argp in the source. Adding the original submitter of this package in Cc for final verification. Gregory, do you remember why you added the argp-standalone dependency? Regards, Arnout > --- > package/libpthsem/Config.in | 1 - > package/libpthsem/libpthsem.mk | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/package/libpthsem/Config.in b/package/libpthsem/Config.in > index 932acec..3219de1 100644 > --- a/package/libpthsem/Config.in > +++ b/package/libpthsem/Config.in > @@ -1,7 +1,6 @@ > config BR2_PACKAGE_LIBPTHSEM > bool "libpthsem" > depends on BR2_USE_MMU # fork() > - select BR2_PACKAGE_ARGP_STANDALONE > help > GNU pth is a user mode multi threading library. pthsem is an extend > version, with support for semaphores added. > diff --git a/package/libpthsem/libpthsem.mk b/package/libpthsem/libpthsem.mk > index 7c1de86..f9f6f71 100644 > --- a/package/libpthsem/libpthsem.mk > +++ b/package/libpthsem/libpthsem.mk > @@ -11,7 +11,6 @@ LIBPTHSEM_LICENSE = LGPLv2.1+ > LIBPTHSEM_LICENSE_FILES = COPYING > LIBPTHSEM_AUTORECONF = YES > LIBPTHSEM_INSTALL_STAGING = YES > -LIBPTHSEM_DEPENDENCIES = argp-standalone > LIBPTHSEM_CONFIG_SCRIPTS = pthsem-config > > ifeq ($(BR2_PACKAGE_LIBPTHSEM_COMPAT),y) >
Dear Romain Naour, On Sat, 2 May 2015 12:28:05 +0200, Romain Naour wrote: > argp-standalone provide libargp.a and argp.h which are > never used in libpthsem. > > Signed-off-by: Romain Naour <romain.naour@openwide.fr> > --- > package/libpthsem/Config.in | 1 - > package/libpthsem/libpthsem.mk | 1 - > 2 files changed, 2 deletions(-) Applied, thanks. Thomas
Hi Arnout, All Le 02/05/2015 14:21, Arnout Vandecappelle a écrit : > On 02/05/15 12:28, Romain Naour wrote: >> argp-standalone provide libargp.a and argp.h which are >> never used in libpthsem. >> >> Signed-off-by: Romain Naour <romain.naour@openwide.fr> > > Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> > Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> > Build-test with and without the _COMPAT option, and checked that there is no > reference to argp in the source. > > Adding the original submitter of this package in Cc for final verification. > Gregory, do you remember why you added the argp-standalone dependency? > Peter find why argp-standalone was added to libpthsem: http://git.buildroot.net/buildroot/commit/?id=25206d6e26dc4ce9c272e68876f31d0ca7d30e67 Gregory is also the original submitter of bcusdk package and it seems that he added argp-standalone dependency to libpthsem instead of bcusdk. Thank you Arnout for your review and test. Best regards, Romain > Regards, > Arnout >
diff --git a/package/libpthsem/Config.in b/package/libpthsem/Config.in index 932acec..3219de1 100644 --- a/package/libpthsem/Config.in +++ b/package/libpthsem/Config.in @@ -1,7 +1,6 @@ config BR2_PACKAGE_LIBPTHSEM bool "libpthsem" depends on BR2_USE_MMU # fork() - select BR2_PACKAGE_ARGP_STANDALONE help GNU pth is a user mode multi threading library. pthsem is an extend version, with support for semaphores added. diff --git a/package/libpthsem/libpthsem.mk b/package/libpthsem/libpthsem.mk index 7c1de86..f9f6f71 100644 --- a/package/libpthsem/libpthsem.mk +++ b/package/libpthsem/libpthsem.mk @@ -11,7 +11,6 @@ LIBPTHSEM_LICENSE = LGPLv2.1+ LIBPTHSEM_LICENSE_FILES = COPYING LIBPTHSEM_AUTORECONF = YES LIBPTHSEM_INSTALL_STAGING = YES -LIBPTHSEM_DEPENDENCIES = argp-standalone LIBPTHSEM_CONFIG_SCRIPTS = pthsem-config ifeq ($(BR2_PACKAGE_LIBPTHSEM_COMPAT),y)
argp-standalone provide libargp.a and argp.h which are never used in libpthsem. Signed-off-by: Romain Naour <romain.naour@openwide.fr> --- package/libpthsem/Config.in | 1 - package/libpthsem/libpthsem.mk | 1 - 2 files changed, 2 deletions(-)