| Message ID | 1426352489-19916-1-git-send-email-romain.naour@openwide.fr |
|---|---|
| State | Accepted |
| Headers | show |
Romain, All, On 2015-03-14 18:01 +0100, Romain Naour spake thusly: > The git hash 36413487f05b165dfc82ad307a5a1c36a795e607 no > longer refers to any commit id, even in the previous git tree. > > By reading the Makefile and CHANGELOG.md the last know > release is 3.2.0. > > Switch to the official git tree and use the 3.2.0 release tag. > > Signed-off-by: Romain Naour <romain.naour@openwide.fr> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Some comment, however... > --- > package/zmqpp/zmqpp.mk | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/package/zmqpp/zmqpp.mk b/package/zmqpp/zmqpp.mk > index fbb0260..7efd04b 100644 > --- a/package/zmqpp/zmqpp.mk > +++ b/package/zmqpp/zmqpp.mk > @@ -4,8 +4,8 @@ > # > ################################################################################ > > -ZMQPP_VERSION = 36413487f05b165dfc82ad307a5a1c36a795e607 > -ZMQPP_SITE = $(call github,benjamg,zmqpp,$(ZMQPP_VERSION)) > +ZMQPP_VERSION = 3.2.0 3.2.0 is 1.5-year old, and there has been quite some changes in the repository since then. Would it make sense to use a more recent commit? Regards, Yann E. MORIN. > +ZMQPP_SITE = $(call github,zeromq,zmqpp,$(ZMQPP_VERSION)) > ZMQPP_INSTALL_STAGING = YES > ZMQPP_DEPENDENCIES = zeromq > ZMQPP_LICENSE = LGPLv3+ with exceptions > -- > 1.9.3 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Hi Yann, All, Le 14/03/2015 22:45, Yann E. MORIN a écrit : > Romain, All, > > On 2015-03-14 18:01 +0100, Romain Naour spake thusly: >> The git hash 36413487f05b165dfc82ad307a5a1c36a795e607 no >> longer refers to any commit id, even in the previous git tree. >> >> By reading the Makefile and CHANGELOG.md the last know >> release is 3.2.0. >> >> Switch to the official git tree and use the 3.2.0 release tag. >> >> Signed-off-by: Romain Naour <romain.naour@openwide.fr> > > Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > > Some comment, however... > >> --- >> package/zmqpp/zmqpp.mk | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/package/zmqpp/zmqpp.mk b/package/zmqpp/zmqpp.mk >> index fbb0260..7efd04b 100644 >> --- a/package/zmqpp/zmqpp.mk >> +++ b/package/zmqpp/zmqpp.mk >> @@ -4,8 +4,8 @@ >> # >> ################################################################################ >> >> -ZMQPP_VERSION = 36413487f05b165dfc82ad307a5a1c36a795e607 >> -ZMQPP_SITE = $(call github,benjamg,zmqpp,$(ZMQPP_VERSION)) >> +ZMQPP_VERSION = 3.2.0 > > 3.2.0 is 1.5-year old, and there has been quite some changes in the > repository since then. Would it make sense to use a more recent commit? There is a patch from Maxime to bump to 4.1.1 but this tag appear only on the unofficial git repository. http://patchwork.ozlabs.org/patch/403314/ For now, master branch is at 3.2.0 and the develop branch is at 4.1.1 Thanks for the review. Best regards, Romain > > Regards, > Yann E. MORIN. > >> +ZMQPP_SITE = $(call github,zeromq,zmqpp,$(ZMQPP_VERSION)) >> ZMQPP_INSTALL_STAGING = YES >> ZMQPP_DEPENDENCIES = zeromq >> ZMQPP_LICENSE = LGPLv3+ with exceptions >> -- >> 1.9.3 >> >> _______________________________________________ >> buildroot mailing list >> buildroot@busybox.net >> http://lists.busybox.net/mailman/listinfo/buildroot >
Dear Romain Naour, On Sat, 14 Mar 2015 18:01:28 +0100, Romain Naour wrote: > The git hash 36413487f05b165dfc82ad307a5a1c36a795e607 no > longer refers to any commit id, even in the previous git tree. > > By reading the Makefile and CHANGELOG.md the last know > release is 3.2.0. > > Switch to the official git tree and use the 3.2.0 release tag. > > Signed-off-by: Romain Naour <romain.naour@openwide.fr> Both patches applied, thanks! Thomas
diff --git a/package/zmqpp/zmqpp.mk b/package/zmqpp/zmqpp.mk index fbb0260..7efd04b 100644 --- a/package/zmqpp/zmqpp.mk +++ b/package/zmqpp/zmqpp.mk @@ -4,8 +4,8 @@ # ################################################################################ -ZMQPP_VERSION = 36413487f05b165dfc82ad307a5a1c36a795e607 -ZMQPP_SITE = $(call github,benjamg,zmqpp,$(ZMQPP_VERSION)) +ZMQPP_VERSION = 3.2.0 +ZMQPP_SITE = $(call github,zeromq,zmqpp,$(ZMQPP_VERSION)) ZMQPP_INSTALL_STAGING = YES ZMQPP_DEPENDENCIES = zeromq ZMQPP_LICENSE = LGPLv3+ with exceptions
The git hash 36413487f05b165dfc82ad307a5a1c36a795e607 no longer refers to any commit id, even in the previous git tree. By reading the Makefile and CHANGELOG.md the last know release is 3.2.0. Switch to the official git tree and use the 3.2.0 release tag. Signed-off-by: Romain Naour <romain.naour@openwide.fr> --- package/zmqpp/zmqpp.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)