diff mbox

sunxi-mali: require fbset

Message ID 1426023433-24991-1-git-send-email-jerome.oufella@savoirfairelinux.com
State Rejected
Headers show

Commit Message

Jérôme Oufella March 10, 2015, 9:37 p.m. UTC 
From: Jérôme Oufella <jerome.oufella@savoirfairelinux.com>

The S80mali startup scripts depends on the presence of the fbset utility
to configure the display settings. To address this, select
BR2_PACKAGE_FBSET for the matter.

Signed-off-by: Jerome Oufella <jerome.oufella@savoirfairelinux.com>
---
 package/sunxi-mali/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Petazzoni March 10, 2015, 10:35 p.m. UTC | #1 
Dear Jerome Oufella,

On Tue, 10 Mar 2015 17:37:13 -0400, Jerome Oufella wrote:
> From: Jérôme Oufella <jerome.oufella@savoirfairelinux.com>
> 
> The S80mali startup scripts depends on the presence of the fbset utility
> to configure the display settings. To address this, select
> BR2_PACKAGE_FBSET for the matter.
> 
> Signed-off-by: Jerome Oufella <jerome.oufella@savoirfairelinux.com>

Well, there is also a fbset applet in Busybox, which is enabled in our
default Busybox configuration. So normally, the out of the box user
experience should be just fine.

Are you running without Busybox? Or with a custom Busybox configuration?

Best regards,

Thomas
Jérôme Oufella March 11, 2015, 3:44 a.m. UTC | #2 
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

> Well, there is also a fbset applet in Busybox, which is enabled in our
> default Busybox configuration. So normally, the out of the box user
> experience should be just fine.
>
> Are you running without Busybox? Or with a custom Busybox configuration?

You are the voice of rightness Thomas :-) I had removed the fbset
package executable without reinstalling busybox. As a result, no trace
of fbset with my default config, which led to this patch.

Sorry for the noise.
diff mbox

Patch

diff --git a/package/sunxi-mali/Config.in b/package/sunxi-mali/Config.in
index c95ebbb..9a4eecc 100644
--- a/package/sunxi-mali/Config.in
+++ b/package/sunxi-mali/Config.in
@@ -1,5 +1,6 @@ 
 config BR2_PACKAGE_SUNXI_MALI
 	bool "sunxi-mali"
+	select BR2_PACKAGE_FBSET
 	select BR2_PACKAGE_HAS_LIBEGL
 	select BR2_PACKAGE_HAS_LIBGLES
 	# The egl/gles mali libraries are provided as a git submodule of the