diff mbox

package/kodi: fix a runtime bug (no text displayed in GUI) when an external glibc toolchain is used

Message ID 1425502935-18002-1-git-send-email-julien.boibessot@free.fr
State Changes Requested
Headers show

Commit Message

Julien Boibessot March 4, 2015, 9:02 p.m. UTC 
From: Julien Boibessot <julien.boibessot@armadeus.com>

Problem seen on Sourcery CodeBench ARM 2014.05 toolchain.

Signed-off-by: Julien Boibessot <julien.boibessot@armadeus.com>
---
 package/kodi/Config.in |    7 +++++++
 1 file changed, 7 insertions(+)

Comments

Thomas Petazzoni March 4, 2015, 9:11 p.m. UTC | #1 
Dear julien.boibessot@free.fr,

On Wed,  4 Mar 2015 22:02:15 +0100, julien.boibessot@free.fr wrote:

> +# Otherwise no text is displayed in user interface when compiled with an
> +# external glibc toolchain (iconv_open() is required at runtime for UTF-8 to
> +# UTF-32 conversion)
> +comment "kodi needs an external glibc toolchain which copy gconv libraries"
> +	depends on BR2_PACKAGE_KODI_ARCH_SUPPORTS && BR2_TOOLCHAIN_EXTERNAL_GLIBC
> +	depends on !BR2_TOOLCHAIN_GLIBC_GCONV_LIBS_COPY

As suggested by Yann, what about:

	select BR2_TOOLCHAIN_GLIBC_GCONV_LIBS_COPY if BR2_TOOLCHAIN_EXTERNAL_GLIBC

 ?

Thanks,

Thomas
Julien Boibessot March 5, 2015, 6:37 p.m. UTC | #2 
Hello Thomas,

On 03/04/2015 10:11 PM, Thomas Petazzoni wrote:
> Dear julien.boibessot@free.fr,
>
> On Wed,  4 Mar 2015 22:02:15 +0100, julien.boibessot@free.fr wrote:
>
>> +# Otherwise no text is displayed in user interface when compiled with an
>> +# external glibc toolchain (iconv_open() is required at runtime for UTF-8 to
>> +# UTF-32 conversion)
>> +comment "kodi needs an external glibc toolchain which copy gconv libraries"
>> +	depends on BR2_PACKAGE_KODI_ARCH_SUPPORTS && BR2_TOOLCHAIN_EXTERNAL_GLIBC
>> +	depends on !BR2_TOOLCHAIN_GLIBC_GCONV_LIBS_COPY
> As suggested by Yann, what about:
>
> 	select BR2_TOOLCHAIN_GLIBC_GCONV_LIBS_COPY if BR2_TOOLCHAIN_EXTERNAL_GLIBC
>
>  ?

I didn't know it was possible, :-), so let me check it and come back to
you ASAP.

Regards,
Julien
diff mbox

Patch

diff --git a/package/kodi/Config.in b/package/kodi/Config.in
index 74aeb72..a6e1560 100644
--- a/package/kodi/Config.in
+++ b/package/kodi/Config.in
@@ -7,6 +7,13 @@  comment "kodi needs a toolchain w/ C++, IPv6, largefile, threads, wchar"
 	depends on !BR2_INET_IPV6 || !BR2_INSTALL_LIBSTDCPP || !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
 	depends on BR2_USE_MMU
 
+# Otherwise no text is displayed in user interface when compiled with an
+# external glibc toolchain (iconv_open() is required at runtime for UTF-8 to
+# UTF-32 conversion)
+comment "kodi needs an external glibc toolchain which copy gconv libraries"
+	depends on BR2_PACKAGE_KODI_ARCH_SUPPORTS && BR2_TOOLCHAIN_EXTERNAL_GLIBC
+	depends on !BR2_TOOLCHAIN_GLIBC_GCONV_LIBS_COPY
+
 config BR2_PACKAGE_KODI_EGL_GLES
 	bool
 	default y