[09/14,v6] package/nvidia-driver: add NVidia's OpenGL binary blob

Dear Yann E. MORIN,

On Sat, 24 Jan 2015 00:24:38 +0100, Yann E. MORIN wrote:
> This patch only adds the userland part. Unless other such other packages
> (which we named like: rpi-userland), we do not replicate this naming
> scheme with this package, as a future patch will also enable building
> the kernel part of the driver. So, it is better to just name that
> package with -driver, rather than with -userland and renaming it
> afterwards.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

I've applied to next, after doing some changes:

    [Thomas:
     - Rewrap Config.in help text.
     - Add a comment to explain why mesa3d-headers, xlib_libX11 and
       xlib_libXext are part of the dependencies.
     - Fix typo in comment about library installation: s/The/Then/
     - Use 'addsuffix' instead of 'patsubst' to calculate the final
       filename of libraries to install.
     - Use more temporary variables to make the library installation
    loop clearer: 'libpath' is the relative path of the library in
       nvidia-driver sources, 'libname' the base name of the library,
       'libsoname' the soname of the library, and 'baseso' the base .so
       symlink name.]

See my diff below for the details.

However, one thing that I find a bit unclear and that might need
improvement is that you are making this package depend on X.org while
it does provide an EGL implementation. So you install the 36 MB
libnvidia-eglcore.so.346.35 unconditionally, even though I believe it's
probably unused when X.org is used.

Same for libGLES: do we really need to install both libGL and libGLES ?
Though I agree libGLES* are very small.

So I believe at least the EGL stuff should be separated out: either you
do X.org, or you do EGL. But I don't think both can be used at the same
time. Doing this would allow to drastically cut the installed size of
this huge package.

So now, the diff of the changes I made:



Thomas

Thomas, All,

On 2015-02-21 18:39 +0100, Thomas Petazzoni spake thusly:
> On Sat, 24 Jan 2015 00:24:38 +0100, Yann E. MORIN wrote:
> > This patch only adds the userland part. Unless other such other packages
> > (which we named like: rpi-userland), we do not replicate this naming
> > scheme with this package, as a future patch will also enable building
> > the kernel part of the driver. So, it is better to just name that
> > package with -driver, rather than with -userland and renaming it
> > afterwards.
> > 
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> I've applied to next, after doing some changes:
[--SNIP--]
> However, one thing that I find a bit unclear and that might need
> improvement is that you are making this package depend on X.org while
> it does provide an EGL implementation. So you install the 36 MB
> libnvidia-eglcore.so.346.35 unconditionally, even though I believe it's
> probably unused when X.org is used.
> 
> Same for libGLES: do we really need to install both libGL and libGLES ?
> Though I agree libGLES* are very small.

Well, I just did reproduce what the standard install procedure of the
package does: it installs everything. Agreed, I did not even try to
think those things apart.

> So I believe at least the EGL stuff should be separated out: either you
> do X.org, or you do EGL. But I don't think both can be used at the same
> time. Doing this would allow to drastically cut the installed size of
> this huge package.

Well, it is indeed quite huge, but also consider the type of systems it
is supposed to run on: desktop-class machines. The only embedded-class
board I know of that has an NVidia GPU is the newly introduced Jetson
TK1, and it has 16GiB of on-board eMMC...

> So now, the diff of the changes I made:

Thanks for this cleanup pass! :-)

Regards,
Yann E. MORIN.