| Message ID | 1423748972-17471-3-git-send-email-angelo.compagnucci@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
Dear Angelo Compagnucci, On Thu, 12 Feb 2015 14:49:31 +0100, Angelo Compagnucci wrote: > This patch sets the default timezone to UTC if not overwritten. > Some packages need a configured system timezone for properly > operating like mono based software. > > Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com> > --- > system/Config.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/system/Config.in b/system/Config.in > index 95e10ab..d967002 100644 > --- a/system/Config.in > +++ b/system/Config.in > @@ -371,6 +371,7 @@ config BR2_TARGET_TZ_ZONELIST > > config BR2_TARGET_LOCALTIME > string "default local time" > + default "Etc/UTC" > help > The time zone to install as the default local time, expressed as a > tzdata location, such as: Can you give more details as to what doesn't work with the current default of an empty local time? An empty local time already means UTC, so there should be no need to specify Etc/UTC as the local time. Improving the commit log to give more details about the exact failure solved by this patch would be useful. Thanks, Thomas
Dear Thomas Petazzoni, 2015-02-14 8:36 GMT+01:00 Thomas Petazzoni <thomas.petazzoni@free-electrons.com>: > Dear Angelo Compagnucci, > > On Thu, 12 Feb 2015 14:49:31 +0100, Angelo Compagnucci wrote: >> This patch sets the default timezone to UTC if not overwritten. >> Some packages need a configured system timezone for properly >> operating like mono based software. >> >> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com> >> --- >> system/Config.in | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/system/Config.in b/system/Config.in >> index 95e10ab..d967002 100644 >> --- a/system/Config.in >> +++ b/system/Config.in >> @@ -371,6 +371,7 @@ config BR2_TARGET_TZ_ZONELIST >> >> config BR2_TARGET_LOCALTIME >> string "default local time" >> + default "Etc/UTC" >> help >> The time zone to install as the default local time, expressed as a >> tzdata location, such as: > > Can you give more details as to what doesn't work with the current > default of an empty local time? An empty local time already means UTC, > so there should be no need to specify Etc/UTC as the local time. > > Improving the commit log to give more details about the exact failure > solved by this patch would be useful. I just discovered that problems is in the whole Mono libraries, not only in gtk#. Without /etc/timezone and /etc/localtime files this is the error: System.TimeZoneNotFoundException: Exception of type 'System.TimeZoneNotFoundException' was thrown. at System.TimeZoneInfo.get_Local () [0x00000] in <filename unknown>:0 at System.CurrentSystemTimeZone.GetUtcOffset (DateTime time) [0x00000] in <filename unknown>:0 at System.TimeZone.GetLocalTimeDiff (DateTime time) [0x00000] in <filename unknown>:0 at System.DateTime.get_Now () [0x00000] in <filename unknown>:0 at MainClass.Main (System.String[] args) [0x00000] in <filename unknown>:0 [ERROR] FATAL UNHANDLED EXCEPTION: System.TimeZoneNotFoundException: Exception of type 'System.TimeZoneNotFoundException' was thrown. at System.TimeZoneInfo.get_Local () [0x00000] in <filename unknown>:0 at System.CurrentSystemTimeZone.GetUtcOffset (DateTime time) [0x00000] in <filename unknown>:0 at System.TimeZone.GetLocalTimeDiff (DateTime time) [0x00000] in <filename unknown>:0 at System.DateTime.get_Now () [0x00000] in <filename unknown>:0 at MainClass.Main (System.String[] args) [0x00000] in <filename unknown>:0 Mono libraries wants an explicit localtime to work, cannot be empty. I do you suggest to solve this problem? Obviously it belongs to the mono package, but how to solve it in a clean way? > > Thanks, > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com
Angelo, All, On 2015-02-12 14:49 +0100, Angelo Compagnucci spake thusly: > This patch sets the default timezone to UTC if not overwritten. > Some packages need a configured system timezone for properly > operating like mono based software. > > Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com> I was at first a bit sceptic about the "Etc/" prefix, but indeed, UTC is not a "top-level" timezone; I was confusing it with GMT, which is a "top-level" timezone. So: Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Regards, Yann E. MORIN. > --- > system/Config.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/system/Config.in b/system/Config.in > index 95e10ab..d967002 100644 > --- a/system/Config.in > +++ b/system/Config.in > @@ -371,6 +371,7 @@ config BR2_TARGET_TZ_ZONELIST > > config BR2_TARGET_LOCALTIME > string "default local time" > + default "Etc/UTC" > help > The time zone to install as the default local time, expressed as a > tzdata location, such as: > -- > 1.9.1 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Dear Angelo Compagnucci, On Thu, 12 Feb 2015 14:49:31 +0100, Angelo Compagnucci wrote: > This patch sets the default timezone to UTC if not overwritten. > Some packages need a configured system timezone for properly > operating like mono based software. > > Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com> Applied to next, thanks! Thomas
diff --git a/system/Config.in b/system/Config.in index 95e10ab..d967002 100644 --- a/system/Config.in +++ b/system/Config.in @@ -371,6 +371,7 @@ config BR2_TARGET_TZ_ZONELIST config BR2_TARGET_LOCALTIME string "default local time" + default "Etc/UTC" help The time zone to install as the default local time, expressed as a tzdata location, such as:
This patch sets the default timezone to UTC if not overwritten. Some packages need a configured system timezone for properly operating like mono based software. Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com> --- system/Config.in | 1 + 1 file changed, 1 insertion(+)