| Message ID | 1423437730-22997-2-git-send-email-romain.naour@openwide.fr |
|---|---|
| State | Accepted |
| Headers | show |
Dear Romain Naour, On Mon, 9 Feb 2015 00:22:09 +0100, Romain Naour wrote: > Backport a patch from Fedora > > Signed-off-by: Romain Naour <romain.naour@openwide.fr> > --- > package/openvmtools/0007-sizeof_argument.patch | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > create mode 100644 package/openvmtools/0007-sizeof_argument.patch Applied to master, thanks. Note that Debian also has a collection of patches on open-vm-tools, and at least two of them seem to fix security related issues. Is this stuff still maintained upstream? They have apparently moved their development to github, at https://github.com/vmware/open-vm-tools. Can you check if those patches were merged here already? Thanks! Thomas
Hi Thomas, Le 14/02/2015 09:20, Thomas Petazzoni a écrit : > Dear Romain Naour, > > On Mon, 9 Feb 2015 00:22:09 +0100, Romain Naour wrote: >> Backport a patch from Fedora >> >> Signed-off-by: Romain Naour <romain.naour@openwide.fr> >> --- >> package/openvmtools/0007-sizeof_argument.patch | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> create mode 100644 package/openvmtools/0007-sizeof_argument.patch > > Applied to master, thanks. > > Note that Debian also has a collection of patches on open-vm-tools, and > at least two of them seem to fix security related issues. Is this stuff > still maintained upstream? They have apparently moved their development > to github, at https://github.com/vmware/open-vm-tools. > Indeed, I've cloned this repository to check if the Fedora patches were merged. It seems that it is still maintained, but not on regular basis. I think the two patches from Debian needs further testing... Karoly can you review those patches ? In the meantime, I'll try to have some time next week to test this package with our VWware image at work. > Can you check if those patches were merged here already? Not yet, the last commit has been merged the 28/10/2014. Best regards, Romain > > Thanks! > > Thomas >
Hi Romain, Thomas, list, > > Note that Debian also has a collection of patches on open-vm-tools, and > > at least two of them seem to fix security related issues. Is this stuff > > still maintained upstream? They have apparently moved their development > > to github, at https://github.com/vmware/open-vm-tools. > > Indeed, I've cloned this repository to check if the Fedora patches were > merged. > It seems that it is still maintained, but not on regular basis. > > I think the two patches from Debian needs further testing... > Karoly can you review those patches ? > > Of course, I'll add those to my (sadly ever growing) to-do list. Hopefully I can do it sometime this week. I promised a new Inetutils revision too to Thomas, but it is only half done yet. Kind regards Karoly
Dear Károly Kasza, On Sun, 15 Feb 2015 21:55:04 +0100, Károly Kasza wrote: > Of course, I'll add those to my (sadly ever growing) to-do list. Hopefully > I can do it sometime this week. No problem! > I promised a new Inetutils revision too to Thomas, but it is only half done > yet. Great, thanks! Thomas
Hi Karoly, Thomas, all, Le 15/02/2015 21:55, Károly Kasza a écrit : > Hi Romain, Thomas, list, > > > > Note that Debian also has a collection of patches on open-vm-tools, and > > at least two of them seem to fix security related issues. Is this stuff > > still maintained upstream? They have apparently moved their development > > to github, at https://github.com/vmware/open-vm-tools. > > Indeed, I've cloned this repository to check if the Fedora patches were merged. > It seems that it is still maintained, but not on regular basis. > > I think the two patches from Debian needs further testing... > Karoly can you review those patches ? > > > Of course, I'll add those to my (sadly ever growing) to-do list. Hopefully I can > do it sometime this week. > I promised a new Inetutils revision too to Thomas, but it is only half done yet. Great :) On my side, I completed the open-vm-tools package to be able to build and install the open-vm-tools's kernel module. I have successfully tested the vmhgfs.ko module by sharing a folder between the host and the guest. I'm using a 3.2 kernel but the build is broken for recent kernel (I tried with a 3.14 kernel) I applied most of the patches from debian, fedora and archlinux but I need further testing. Best regards, Romain > Kind regards > Karoly > >
diff --git a/package/openvmtools/0007-sizeof_argument.patch b/package/openvmtools/0007-sizeof_argument.patch new file mode 100644 index 0000000..ec2a3f6 --- /dev/null +++ b/package/openvmtools/0007-sizeof_argument.patch @@ -0,0 +1,18 @@ +Patch from Fedora: + +http://pkgs.fedoraproject.org/cgit/open-vm-tools.git/commit/sizeof_argument.patch?id=3031fb5279096189aeb50d197b02313c12d701f3 + +Signed-off-by: Romain Naour <romain.naour@openwide.fr> + +--- open-vm-tools-9.4.6-1770165.orig/lib/syncDriver/syncDriverPosix.c 2014-07-15 13:42:21.043818478 -0700 ++++ open-vm-tools-9.4.6-1770165/lib/syncDriver/syncDriverPosix.c 2014-07-15 13:55:41.724103304 -0700 +@@ -72,8 +72,7 @@ + size_t i; + + for (i = 0; i < ARRAYSIZE(gRemoteFSTypes); i++) { +- if (Str_Strncmp(fsType, gRemoteFSTypes[i], +- sizeof gRemoteFSTypes[i]) == 0) { ++ if (Str_Strcmp(gRemoteFSTypes[i], fsType) == 0) { + return TRUE; + } + }
Backport a patch from Fedora Signed-off-by: Romain Naour <romain.naour@openwide.fr> --- package/openvmtools/0007-sizeof_argument.patch | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 package/openvmtools/0007-sizeof_argument.patch