diff mbox

bootstrap: remove development/debug files

Message ID 1421094218-2999-1-git-send-email-yegorslists@googlemail.com
State Superseded
Headers show

Commit Message

Yegor Yefremov Jan. 12, 2015, 8:23 p.m. UTC
*.min.* files are sufficient for a production system, so
remove other files, that will be used during development
stage.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 package/bootstrap/bootstrap.mk | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Thomas Petazzoni Jan. 12, 2015, 9 p.m. UTC | #1
Dear Yegor Yefremov,

On Mon, 12 Jan 2015 21:23:38 +0100, Yegor Yefremov wrote:
> *.min.* files are sufficient for a production system, so
> remove other files, that will be used during development
> stage.
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
>  package/bootstrap/bootstrap.mk | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/package/bootstrap/bootstrap.mk b/package/bootstrap/bootstrap.mk
> index 1bf8aa2..f79a00f 100644
> --- a/package/bootstrap/bootstrap.mk
> +++ b/package/bootstrap/bootstrap.mk
> @@ -16,6 +16,11 @@ endef
>  define BOOTSTRAP_INSTALL_TARGET_CMDS
>  	mkdir -p $(TARGET_DIR)/var/www/bootstrap
>  	cp -dpfr $(@D)/dist/* $(TARGET_DIR)/var/www/bootstrap
> +
> +	rm $(TARGET_DIR)/var/www/bootstrap/css/bootstrap-theme.css*
> +	rm $(TARGET_DIR)/var/www/bootstrap/css/bootstrap.css*
> +	rm $(TARGET_DIR)/var/www/bootstrap/js/npm.js
> +	rm $(TARGET_DIR)/var/www/bootstrap/js/bootstrap.js
>  endef
>  
>  $(eval $(generic-package))

At this point, I am wondering if it is not simpler/shorter to install
only the necessary files, rather than install everything and remove
what's unneeded. Can you compare the two options?

Thanks,

Thomas
diff mbox

Patch

diff --git a/package/bootstrap/bootstrap.mk b/package/bootstrap/bootstrap.mk
index 1bf8aa2..f79a00f 100644
--- a/package/bootstrap/bootstrap.mk
+++ b/package/bootstrap/bootstrap.mk
@@ -16,6 +16,11 @@  endef
 define BOOTSTRAP_INSTALL_TARGET_CMDS
 	mkdir -p $(TARGET_DIR)/var/www/bootstrap
 	cp -dpfr $(@D)/dist/* $(TARGET_DIR)/var/www/bootstrap
+
+	rm $(TARGET_DIR)/var/www/bootstrap/css/bootstrap-theme.css*
+	rm $(TARGET_DIR)/var/www/bootstrap/css/bootstrap.css*
+	rm $(TARGET_DIR)/var/www/bootstrap/js/npm.js
+	rm $(TARGET_DIR)/var/www/bootstrap/js/bootstrap.js
 endef
 
 $(eval $(generic-package))