| Message ID | 1417642895-29606-5-git-send-email-thomas.petazzoni@free-electrons.com |
|---|---|
| State | Accepted |
| Headers | show |
Thomas, All, On 2014-12-03 22:41 +0100, Thomas Petazzoni spake thusly: > Currently, the binary format choice is only shown for the Blackfin and > m68k architectures, since we assume that all other architectures are > using the ELF binary format. However, due to this, the BR2_BINFMT_ELF > symbol is in fact not set to 'y' for those architectures that use the > ELF format. > > This will be causing problems for the refactoring of the static/shared > library support, as we will need to know if the binary format supports > shared libraries or not. > > Therefore, we simply make the choice visible on all architectures, > even if it means that on many architectures no other choice than ELF > will be available. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Even though BR2_BINFMT_ELF is never used, but we need it in the choice. Just out of curiosity, do you plan on needing it in a future patch? Regards, Yann E. MORIN. > --- > arch/Config.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/Config.in b/arch/Config.in > index 3bac187..c05e5d7 100644 > --- a/arch/Config.in > +++ b/arch/Config.in > @@ -254,7 +254,7 @@ config BR2_ARCH_HAS_ATOMICS > # Set up target binary format > choice > prompt "Target Binary Format" > - depends on BR2_bfin || BR2_m68k > + default BR2_BINFMT_ELF if !(BR2_bfin || BR2_m68k) > default BR2_BINFMT_FDPIC if BR2_bfin > default BR2_BINFMT_FLAT if BR2_m68k > > -- > 2.1.0 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Dear Yann E. MORIN, On Thu, 11 Dec 2014 21:07:08 +0100, Yann E. MORIN wrote: > Even though BR2_BINFMT_ELF is never used, but we need it in the choice. > Just out of curiosity, do you plan on needing it in a future patch? Well it is needed in PATCH 5/8 to make sure that BR2_BINFMT_SUPPORTS_SHARED is selected on ELF based systems. Thomas
diff --git a/arch/Config.in b/arch/Config.in index 3bac187..c05e5d7 100644 --- a/arch/Config.in +++ b/arch/Config.in @@ -254,7 +254,7 @@ config BR2_ARCH_HAS_ATOMICS # Set up target binary format choice prompt "Target Binary Format" - depends on BR2_bfin || BR2_m68k + default BR2_BINFMT_ELF if !(BR2_bfin || BR2_m68k) default BR2_BINFMT_FDPIC if BR2_bfin default BR2_BINFMT_FLAT if BR2_m68k
Currently, the binary format choice is only shown for the Blackfin and m68k architectures, since we assume that all other architectures are using the ELF binary format. However, due to this, the BR2_BINFMT_ELF symbol is in fact not set to 'y' for those architectures that use the ELF format. This will be causing problems for the refactoring of the static/shared library support, as we will need to know if the binary format supports shared libraries or not. Therefore, we simply make the choice visible on all architectures, even if it means that on many architectures no other choice than ELF will be available. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- arch/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)