diff mbox

[U-Boot,4/4] x86: Remove unnecessary call to initr_enable_interrupts()

Message ID 1416471087-16228-1-git-send-email-bmeng.cn@gmail.com
State Accepted
Delegated to: Simon Glass
Headers show

Commit Message

Bin Meng Nov. 20, 2014, 8:11 a.m. UTC
Actually initr_enable_interrupts() was never called in an x86 build
due to it was wrapped by CONFIG_x86 (typo of X86).

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---
 common/board_r.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Glass Nov. 25, 2014, 3:06 a.m. UTC | #1
On 20 November 2014 at 01:11, Bin Meng <bmeng.cn@gmail.com> wrote:
> Actually initr_enable_interrupts() was never called in an x86 build
> due to it was wrapped by CONFIG_x86 (typo of X86).
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>  common/board_r.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Simon Glass <sjg@chromium.org>

Tested on chromebook_link:
Tested-by: Simon Glass <sjg@chromium.org>
Simon Glass Nov. 25, 2014, 3:42 a.m. UTC | #2
On 24 November 2014 at 20:06, Simon Glass <sjg@chromium.org> wrote:
> On 20 November 2014 at 01:11, Bin Meng <bmeng.cn@gmail.com> wrote:
>> Actually initr_enable_interrupts() was never called in an x86 build
>> due to it was wrapped by CONFIG_x86 (typo of X86).
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> ---
>>  common/board_r.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Acked-by: Simon Glass <sjg@chromium.org>
>
> Tested on chromebook_link:
> Tested-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-x86, thanks!
diff mbox

Patch

diff --git a/common/board_r.c b/common/board_r.c
index b5ea030..128fcce 100644
--- a/common/board_r.c
+++ b/common/board_r.c
@@ -841,7 +841,7 @@  init_fnc_t init_sequence_r[] = {
 	board_early_init_r,
 #endif
 	interrupt_init,
-#if defined(CONFIG_ARM) || defined(CONFIG_x86)
+#if defined(CONFIG_ARM)
 	initr_enable_interrupts,
 #endif
 #ifdef CONFIG_X86