diff mbox

eudev: add input group

Message ID 1413838745-14008-1-git-send-email-gustavo@zacarias.com.ar
State Superseded
Headers show

Commit Message

Gustavo Zacarias Oct. 20, 2014, 8:59 p.m. UTC
It's used by 50-default-udev.rules for input-class devices.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/eudev/eudev.mk | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Thomas Petazzoni Oct. 20, 2014, 9:18 p.m. UTC | #1
Dear Gustavo Zacarias,

On Mon, 20 Oct 2014 17:59:05 -0300, Gustavo Zacarias wrote:
> It's used by 50-default-udev.rules for input-class devices.
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
>  package/eudev/eudev.mk | 5 +++++
>  1 file changed, 5 insertions(+)

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

I've seen the same issue a couple of days ago.

Does systemd needs a similar fix?

Thomas
Samuel Martin Oct. 20, 2014, 9:24 p.m. UTC | #2
On Mon, Oct 20, 2014 at 11:18 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Gustavo Zacarias,
>
> On Mon, 20 Oct 2014 17:59:05 -0300, Gustavo Zacarias wrote:
>> It's used by 50-default-udev.rules for input-class devices.
>>
>> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
>> ---
>>  package/eudev/eudev.mk | 5 +++++
>>  1 file changed, 5 insertions(+)
>
> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>
> I've seen the same issue a couple of days ago.
>
> Does systemd needs a similar fix?

I think so.

It is not that much about systemd, but more about udev rules that
would try to set the ownership to some group that does not exist.

Regards,
Eric Le Bihan Oct. 21, 2014, 7:58 a.m. UTC | #3
Hi!

On Mon, Oct 20, 2014 at 11:18:02PM +0200, Thomas Petazzoni wrote:
> Dear Gustavo Zacarias,
>
> On Mon, 20 Oct 2014 17:59:05 -0300, Gustavo Zacarias wrote:
> > It's used by 50-default-udev.rules for input-class devices.
> >
> > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> > ---
> >  package/eudev/eudev.mk | 5 +++++
> >  1 file changed, 5 insertions(+)
>
> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>
> I've seen the same issue a couple of days ago.
>
> Does systemd needs a similar fix?

Yes it does.

In my setup, I modified system/skeleton/etc/group to add "input:x:31:"

I'll send a patch similar to the eudev one.

Best regards
ELB
Gustavo Zacarias Oct. 21, 2014, 1:15 p.m. UTC | #4
On 10/21/2014 04:58 AM, Eric Le Bihan wrote:

>> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>>
>> I've seen the same issue a couple of days ago.
>>
>> Does systemd needs a similar fix?
> 
> Yes it does.
> 
> In my setup, I modified system/skeleton/etc/group to add "input:x:31:"
> 
> I'll send a patch similar to the eudev one.

Hold off on applying the patch, mkusers doesn't handle making groups
without users gracefully:

...scripts/mkusers: line 369: [: too many arguments
...scripts/mkusers: line 376: [: too many arguments
...scripts/mkusers: line 400: [: input: integer expression expected
...scripts/mkusers: line 408: [: input: integer expression expected

I can respin adding an input user to match, another option is to handle
the scenario in mkusers.
Regards.
Yann E. MORIN Oct. 21, 2014, 4:28 p.m. UTC | #5
Gustavo, All,

On 2014-10-21 10:15 -0300, Gustavo Zacarias spake thusly:
> On 10/21/2014 04:58 AM, Eric Le Bihan wrote:
> 
> >> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> >>
> >> I've seen the same issue a couple of days ago.
> >>
> >> Does systemd needs a similar fix?
> > 
> > Yes it does.
> > 
> > In my setup, I modified system/skeleton/etc/group to add "input:x:31:"
> > 
> > I'll send a patch similar to the eudev one.
> 
> Hold off on applying the patch, mkusers doesn't handle making groups
> without users gracefully:
> 
> ...scripts/mkusers: line 369: [: too many arguments
> ...scripts/mkusers: line 376: [: too many arguments
> ...scripts/mkusers: line 400: [: input: integer expression expected
> ...scripts/mkusers: line 408: [: input: integer expression expected
> 
> I can respin adding an input user to match, another option is to handle
> the scenario in mkusers.

I can look at handling this in mkusers, certainly.

Regards,
Yann E. MORIN.
diff mbox

Patch

diff --git a/package/eudev/eudev.mk b/package/eudev/eudev.mk
index fd935a7..d29f762 100644
--- a/package/eudev/eudev.mk
+++ b/package/eudev/eudev.mk
@@ -42,4 +42,9 @@  define EUDEV_INSTALL_INIT_SYSV
 	$(INSTALL) -m 0755 package/eudev/S10udev $(TARGET_DIR)/etc/init.d/S10udev
 endef
 
+# Required by default rules for input devices
+define EUDEV_USERS
+	'' -1 input -1 * - - - input group
+endef
+
 $(eval $(autotools-package))