diff mbox

[01/11] mesa3d: Fix package requirements

Message ID 1412340212-3089-2-git-send-email-jezz@sysmic.org
State Superseded
Headers show

Commit Message

Jérôme Pouiller Oct. 3, 2014, 12:43 p.m. UTC
mesa3d requirement (as specified by configure script) are:
    x11 xext xdamage xfixes x11-xcb xcb-glx >= 1.8.1 xcb-dri2 >= 1.8
    xcb-dri3 xcb-present xcb-sync xshmfence >= 1.1

Signed-off-by: Jérôme Pouiller <jezz@sysmic.org>
---
 package/mesa3d/Config.in | 3 +++
 package/mesa3d/mesa3d.mk | 3 +++
 2 files changed, 6 insertions(+)

Comments

Bernd Kuhls Oct. 3, 2014, 12:52 p.m. UTC | #1
=?UTF-8?q?J=C3=A9r=C3=B4me=20Pouiller?= <jezz-
kPcTzGkeZgAdnm+yROfE0A@public.gmane.org> wrote in news:1412340212-3089-2-git-
send-email-jezz@sysmic.org:

> +     select BR2_PACKAGE_XPROTO_DRI3PROTO if BR2_PACKAGE_XORG7

Hi,

nack, dri3 is an optional dependency.

Also having dri3 support in mesa3d breaks xbmc on intel systems:
https://github.com/OpenELEC/OpenELEC.tv/commit/b574ad91fe9c7b9fcf627df0d5e3c7
7e262a1f85

Regards, Bernd
Jérôme Pouiller Oct. 3, 2014, 2:14 p.m. UTC | #2
On Friday 03 October 2014 14:52:12 Bernd Kuhls wrote:
> =?UTF-8?q?J=C3=A9r=C3=B4me=20Pouiller?= <jezz-
> kPcTzGkeZgAdnm+yROfE0A@public.gmane.org> wrote in
> news:1412340212-3089-2-git-
> send-email-jezz@sysmic.org:
> > +     select BR2_PACKAGE_XPROTO_DRI3PROTO if BR2_PACKAGE_XORG7
> 
> Hi,
> 
> nack, dri3 is an optional dependency.
> 
> Also having dri3 support in mesa3d breaks xbmc on intel systems:
> https://github.com/OpenELEC/OpenELEC.tv/commit/b574ad91fe9c7b9fcf627df0d5e3c
> 7 7e262a1f85
I encountered problems with dri3 dependencies during my tests. By checking 
code more closely, my problems happens only if no DRI was selected. I will fix 
that.
Bernd Kuhls Oct. 3, 2014, 2:28 p.m. UTC | #3
Jérôme Pouiller <jezz@sysmic.org> wrote in
news:3045501.26YYGqRTnd@sagittea: 

> I encountered problems with dri3 dependencies during my tests. By
> checking code more closely, my problems happens only if no DRI was
> selected. I will fix that. 
> 

Hi,

did you test with latest buildroot git master?
It includes this patch which should fix the problem:

http://git.buildroot.net/buildroot/commit/package/mesa3d/mesa3d.mk?
id=d0edceb9d4e9ba6536af5b6687e8523f1c5ea5d1

If it does not fix the problem please post the error message.

Regards, Bernd
Jérôme Pouiller Oct. 3, 2014, 2:33 p.m. UTC | #4
On Friday 03 October 2014 16:14:04 Jérôme Pouiller wrote:
> On Friday 03 October 2014 14:52:12 Bernd Kuhls wrote:
> > =?UTF-8?q?J=C3=A9r=C3=B4me=20Pouiller?= <jezz-
> > kPcTzGkeZgAdnm+yROfE0A@public.gmane.org> wrote in
> > news:1412340212-3089-2-git-
> > 
> > send-email-jezz@sysmic.org:
> > > +     select BR2_PACKAGE_XPROTO_DRI3PROTO if BR2_PACKAGE_XORG7
> > 
> > Hi,
> > 
> > nack, dri3 is an optional dependency.
> > 
> > Also having dri3 support in mesa3d breaks xbmc on intel systems:
> > https://github.com/OpenELEC/OpenELEC.tv/commit/b574ad91fe9c7b9fcf627df0d5e
> > 3c 7 7e262a1f85
> 
> I encountered problems with dri3 dependencies during my tests. By checking
> code more closely, my problems happens only if no DRI was selected. I will
> fix that.
Arf, this was fixed by d0edceb ("mesa3d: fix build without dri drivers"), but 
this breaks xdriver_xf86-video-imx DRI support.
Bernd Kuhls Oct. 3, 2014, 2:45 p.m. UTC | #5
Jérôme Pouiller <jezz@sysmic.org> wrote in
news:1923213.bFy6dBPsRI@sagittea: 

> Arf, this was fixed by d0edceb ("mesa3d: fix build without dri
> drivers"), but this breaks xdriver_xf86-video-imx DRI support.

Hi,

what about adding

depends on BR2_PACKAGE_XPROTO_DRI3PROTO

to package/x11r7/xdriver_xf86-video-imx-viv/Config.in?

Regards, Bernd
Jérôme Pouiller Oct. 3, 2014, 3:02 p.m. UTC | #6
On Friday 03 October 2014 16:45:12 Bernd Kuhls wrote:
> Jérôme Pouiller <jezz@sysmic.org> wrote in
> 
> news:1923213.bFy6dBPsRI@sagittea:
> > Arf, this was fixed by d0edceb ("mesa3d: fix build without dri
> > drivers"), but this breaks xdriver_xf86-video-imx DRI support.
> 
> Hi,
> 
> what about adding
> 
> depends on BR2_PACKAGE_XPROTO_DRI3PROTO
> 
> to package/x11r7/xdriver_xf86-video-imx-viv/Config.in?
I need mesa3d with --enable-dri, even if no DRI drivers are selected. I am 
going to enable DRI if BR2_PACKAGE_MESA3D_DRI_DRIVER is set (currently, it 
ensable if MESA3D_DRI_DRIVERS-y is set). Therefore, I could enable 
BR2_PACKAGE_MESA3D_DRI_DRIVER in xdriver_xf86-video-imx package.

I will resens my serie soon.
diff mbox

Patch

diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
index 74ebbed..673fbe2 100644
--- a/package/mesa3d/Config.in
+++ b/package/mesa3d/Config.in
@@ -2,12 +2,15 @@  menuconfig BR2_PACKAGE_MESA3D
 	bool "mesa3d"
 	select BR2_PACKAGE_LIBDRM
 	select BR2_PACKAGE_EXPAT
+	select BR2_PACKAGE_XPROTO_DRI3PROTO if BR2_PACKAGE_XORG7
 	select BR2_PACKAGE_XPROTO_DRI2PROTO if BR2_PACKAGE_XORG7
 	select BR2_PACKAGE_XPROTO_XF86DRIPROTO if BR2_PACKAGE_XORG7
+	select BR2_PACKAGE_XPROTO_PRESENTPROTO if BR2_PACKAGE_XORG7
 	select BR2_PACKAGE_XLIB_LIBX11 if BR2_PACKAGE_XORG7
 	select BR2_PACKAGE_XLIB_LIBXEXT if BR2_PACKAGE_XORG7
 	select BR2_PACKAGE_XLIB_LIBXDAMAGE if BR2_PACKAGE_XORG7
 	select BR2_PACKAGE_XLIB_LIBXFIXES if BR2_PACKAGE_XORG7
+	select BR2_PACKAGE_XLIB_LIBXSHMFENCE if BR2_PACKAGE_XORG7
 	select BR2_PACKAGE_LIBXCB if BR2_PACKAGE_XORG7
 	depends on BR2_PACKAGE_HAS_UDEV
 	depends on BR2_INSTALL_LIBSTDCPP
diff --git a/package/mesa3d/mesa3d.mk b/package/mesa3d/mesa3d.mk
index ec76872..203a055 100644
--- a/package/mesa3d/mesa3d.mk
+++ b/package/mesa3d/mesa3d.mk
@@ -28,11 +28,14 @@  ifeq ($(BR2_PACKAGE_XORG7),y)
 MESA3D_DEPENDENCIES += \
 	xproto_xf86driproto \
 	xproto_dri2proto \
+	xproto_dri3proto \
+	xproto_presentproto \
 	xproto_glproto \
 	xlib_libX11 \
 	xlib_libXext \
 	xlib_libXdamage \
 	xlib_libXfixes \
+	xlib_libxshmfence \
 	libxcb
 MESA3D_CONF_OPT += --enable-glx
 # quote from mesa3d configure "Building xa requires at least one non swrast gallium driver."