diff mbox

ncurses: Add libcurses symlink to libncurses

Message ID 1411464791-8023-1-git-send-email-Vincent.Riera@imgtec.com
State Accepted
Commit 8733f742b619193fba69daf5f2297f2e89896ade
Headers show

Commit Message

Vicente Olivert Riera Sept. 23, 2014, 9:33 a.m. UTC 
Some packages use -lcurses when they are linking, so they try to link to
a library called libcurses. The library provided by our ncurses package
is called libncurses, so those packages fail to link with a message like
this one:

/bin/ld: cannot find -lcurses

Installing a libcurses symlink to libncurses fixes the problem.

Fixes:
  http://autobuild.buildroot.net/results/466/466995f9534447a4f54327a14c44ef9e16dd1123/

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Reviewed-by: Markos Chandras <Markos.Chandras@imgtec.com>
---
 package/ncurses/ncurses.mk |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

Comments

Thomas Petazzoni Sept. 23, 2014, 9:38 a.m. UTC | #1 
Dear Vicente Olivert Riera,

On Tue, 23 Sep 2014 10:33:11 +0100, Vicente Olivert Riera wrote:
> Some packages use -lcurses when they are linking, so they try to link to
> a library called libcurses. The library provided by our ncurses package
> is called libncurses, so those packages fail to link with a message like
> this one:

Can you define "some" in "Some packages" ?

Thanks!

Thomas
Vicente Olivert Riera Sept. 23, 2014, 9:42 a.m. UTC | #2 
On 09/23/2014 10:38 AM, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
>
> On Tue, 23 Sep 2014 10:33:11 +0100, Vicente Olivert Riera wrote:
>> Some packages use -lcurses when they are linking, so they try to link to
>> a library called libcurses. The library provided by our ncurses package
>> is called libncurses, so those packages fail to link with a message like
>> this one:
>
> Can you define "some" in "Some packages" ?
>
> Thanks!
>
> Thomas

Hi Thomas,

there is an autobuild report at the bottom of the commit message where 
you can see a package which is failing due to that problem.
Thomas Petazzoni Sept. 23, 2014, 9:53 a.m. UTC | #3 
Dear Vicente Olivert Riera,

On Tue, 23 Sep 2014 10:42:23 +0100, Vicente Olivert Riera wrote:

> there is an autobuild report at the bottom of the commit message where 
> you can see a package which is failing due to that problem.

Indeed, I missed it. Sorry for the silly comment. Patch looks good to
me.

Thomas
Peter Korsgaard Sept. 25, 2014, 9:01 a.m. UTC | #4 
>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:

 > Some packages use -lcurses when they are linking, so they try to link to
 > a library called libcurses. The library provided by our ncurses package
 > is called libncurses, so those packages fail to link with a message like
 > this one:

 > /bin/ld: cannot find -lcurses

 > Installing a libcurses symlink to libncurses fixes the problem.

 > Fixes:
 >   http://autobuild.buildroot.net/results/466/466995f9534447a4f54327a14c44ef9e16dd1123/

 > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
 > Reviewed-by: Markos Chandras <Markos.Chandras@imgtec.com>

Committed, thanks.
diff mbox

Patch

diff --git a/package/ncurses/ncurses.mk b/package/ncurses/ncurses.mk
index 81a3998..3f57407 100644
--- a/package/ncurses/ncurses.mk
+++ b/package/ncurses/ncurses.mk
@@ -46,6 +46,8 @@  define NCURSES_LINK_LIBS
 		ln -sf $${lib}$(NCURSES_LIB_SUFFIX).a \
 			$(1)/usr/lib/$${lib}.a; \
 	done
+	ln -sf libncurses$(NCURSES_LIB_SUFFIX).a \
+		$(1)/usr/lib/libcurses.a
 endef
 else
 define NCURSES_LINK_LIBS
@@ -55,6 +57,10 @@  define NCURSES_LINK_LIBS
 		ln -sf $${lib}$(NCURSES_LIB_SUFFIX).so \
 			$(1)/usr/lib/$${lib}.so; \
 	done
+	ln -sf libncurses$(NCURSES_LIB_SUFFIX).a \
+		$(1)/usr/lib/libcurses.a
+	ln -sf libncurses$(NCURSES_LIB_SUFFIX).so \
+		$(1)/usr/lib/libcurses.so
 endef
 endif