| Message ID | 1410814919-11523-3-git-send-email-thomas.petazzoni@free-electrons.com |
|---|---|
| State | Accepted |
| Headers | show |
Thomas, All, On 2014-09-15 23:01 +0200, Thomas Petazzoni spake thusly: > The BR2_arm10t option is not correct as it references an ARM family, > while other options indicate a specific ARM core. The ARM cores in > ARM10 family are ARM1020E, ARM1022E and ARM1026EJ-S according to > Wikipedia. However, those are clearly very rare, and Wikipedia also > indicates two Conexant ADSL-related SoC as being part of this family > of ARM cores. Therefore, this commit removes this ARM family. You forgot the reference to BR2_arm10t we have in nettle.mk Regards, Yann E. MORIN. > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > --- > arch/Config.in.arm | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/arch/Config.in.arm b/arch/Config.in.arm > index 5ae2378..201ff1d 100644 > --- a/arch/Config.in.arm > +++ b/arch/Config.in.arm > @@ -54,9 +54,6 @@ config BR2_arm926t > bool "arm926t" > select BR2_ARM_CPU_MAYBE_HAS_VFPV2 > select BR2_ARM_CPU_HAS_THUMB > -config BR2_arm10t > - bool "arm10t" > - select BR2_ARM_CPU_HAS_THUMB > config BR2_arm1136jf_s_r0 > bool "arm1136jf_s rev0" > select BR2_ARM_CPU_HAS_VFPV2 > @@ -367,7 +364,6 @@ config BR2_GCC_TARGET_ARCH > default "armv4t" if BR2_arm920t > default "armv4t" if BR2_arm922t > default "armv5te" if BR2_arm926t > - default "armv5t" if BR2_arm10t > default "armv6j" if BR2_arm1136jf_s_r0 > default "armv6k" if BR2_arm1136jf_s_r1 > default "armv6zk" if BR2_arm1176jz_s > -- > 2.0.0 >
Dear Yann E. MORIN, On Mon, 15 Sep 2014 23:13:55 +0200, Yann E. MORIN wrote: > Thomas, All, > > On 2014-09-15 23:01 +0200, Thomas Petazzoni spake thusly: > > The BR2_arm10t option is not correct as it references an ARM family, > > while other options indicate a specific ARM core. The ARM cores in > > ARM10 family are ARM1020E, ARM1022E and ARM1026EJ-S according to > > Wikipedia. However, those are clearly very rare, and Wikipedia also > > indicates two Conexant ADSL-related SoC as being part of this family > > of ARM cores. Therefore, this commit removes this ARM family. > > You forgot the reference to BR2_arm10t we have in nettle.mk Gah, indeed, will fix and resend. Also, in the commit log: s/Wikipedia also/Wikipedia only/. Thomas
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes: > The BR2_arm10t option is not correct as it references an ARM family, > while other options indicate a specific ARM core. The ARM cores in > ARM10 family are ARM1020E, ARM1022E and ARM1026EJ-S according to > Wikipedia. However, those are clearly very rare, and Wikipedia also > indicates two Conexant ADSL-related SoC as being part of this family > of ARM cores. Therefore, this commit removes this ARM family. > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Committed with the reference in nettle.mk removed / commit message tweaked, thanks.
diff --git a/arch/Config.in.arm b/arch/Config.in.arm index 5ae2378..201ff1d 100644 --- a/arch/Config.in.arm +++ b/arch/Config.in.arm @@ -54,9 +54,6 @@ config BR2_arm926t bool "arm926t" select BR2_ARM_CPU_MAYBE_HAS_VFPV2 select BR2_ARM_CPU_HAS_THUMB -config BR2_arm10t - bool "arm10t" - select BR2_ARM_CPU_HAS_THUMB config BR2_arm1136jf_s_r0 bool "arm1136jf_s rev0" select BR2_ARM_CPU_HAS_VFPV2 @@ -367,7 +364,6 @@ config BR2_GCC_TARGET_ARCH default "armv4t" if BR2_arm920t default "armv4t" if BR2_arm922t default "armv5te" if BR2_arm926t - default "armv5t" if BR2_arm10t default "armv6j" if BR2_arm1136jf_s_r0 default "armv6k" if BR2_arm1136jf_s_r1 default "armv6zk" if BR2_arm1176jz_s
The BR2_arm10t option is not correct as it references an ARM family, while other options indicate a specific ARM core. The ARM cores in ARM10 family are ARM1020E, ARM1022E and ARM1026EJ-S according to Wikipedia. However, those are clearly very rare, and Wikipedia also indicates two Conexant ADSL-related SoC as being part of this family of ARM cores. Therefore, this commit removes this ARM family. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- arch/Config.in.arm | 4 ---- 1 file changed, 4 deletions(-)