diff mbox

ptpd2: fix static linking

Message ID 1406758585-24577-1-git-send-email-gustavo@zacarias.com.ar
State Accepted
Headers show

Commit Message

Gustavo Zacarias July 30, 2014, 10:16 p.m. UTC
Do the same as in commit b64a06d7b70bd7b160826bf9b97e60e18171913d
to avoid missing libraries needed by libpcap. Fixes:
http://autobuild.buildroot.net/results/1a1/1a1dadfa2b22074d401b013606f0cede66efe826/

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/ptpd2/ptpd2.mk | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Thomas Petazzoni July 31, 2014, 6:19 p.m. UTC | #1
Dear Gustavo Zacarias,

On Wed, 30 Jul 2014 19:16:25 -0300, Gustavo Zacarias wrote:
> Do the same as in commit b64a06d7b70bd7b160826bf9b97e60e18171913d
> to avoid missing libraries needed by libpcap. Fixes:
> http://autobuild.buildroot.net/results/1a1/1a1dadfa2b22074d401b013606f0cede66efe826/
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
>  package/ptpd2/ptpd2.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/ptpd2/ptpd2.mk b/package/ptpd2/ptpd2.mk
> index 3133726..6a6ae60 100644
> --- a/package/ptpd2/ptpd2.mk
> +++ b/package/ptpd2/ptpd2.mk
> @@ -13,6 +13,10 @@ PTPD2_AUTORECONF = YES
>  PTPD2_LICENSE = BSD-2c
>  PTPD2_LICENSE_FILES = COPYRIGHT
>  
> +ifeq ($(BR2_PREFER_STATIC_LIB),y)
> +	PTPD2_CONF_OPT += LIBS="$(shell $(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs)"
> +endif
> +

Applied, thanks. However, I continue to be worried about all those
fixups we do all over the place for static linking, instead of fixing
upstream properly. If upstream suddenly fixes static linking, we won't
even notice.

Thomas
diff mbox

Patch

diff --git a/package/ptpd2/ptpd2.mk b/package/ptpd2/ptpd2.mk
index 3133726..6a6ae60 100644
--- a/package/ptpd2/ptpd2.mk
+++ b/package/ptpd2/ptpd2.mk
@@ -13,6 +13,10 @@  PTPD2_AUTORECONF = YES
 PTPD2_LICENSE = BSD-2c
 PTPD2_LICENSE_FILES = COPYRIGHT
 
+ifeq ($(BR2_PREFER_STATIC_LIB),y)
+	PTPD2_CONF_OPT += LIBS="$(shell $(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs)"
+endif
+
 ifeq ($(BR2_PACKAGE_NETSNMP),y)
 	PTPD2_CONF_ENV += ac_cv_path_PATH_NET_SNMP_CONFIG=$(STAGING_DIR)/usr/bin/net-snmp-config
 	PTPD2_DEPENDENCIES += netsnmp