| Message ID | 1404406406-9209-3-git-send-email-francois.perrad@gadz.org |
|---|---|
| State | Rejected |
| Headers | show |
Dear Francois Perrad, See: this patch has exactly the same title as the previous one. That's a good indication that the title is not sufficiently distinctive. On Thu, 3 Jul 2014 18:53:26 +0200, Francois Perrad wrote: > the following error occurs after the previous patch > arm-none-linux-gnueabi-gcc: error: unrecognized command line option '-shared ' > > so, force LDDLFLAGS without quote > > note: previously LDDLFLAGS was correct > Signed-off-by: Francois Perrad <francois.perrad@gadz.org> > --- > package/perl-net-ssleay/perl-net-ssleay.mk | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/package/perl-net-ssleay/perl-net-ssleay.mk b/package/perl-net-ssleay/perl-net-ssleay.mk > index 7e4c194..48ff715 100644 > --- a/package/perl-net-ssleay/perl-net-ssleay.mk > +++ b/package/perl-net-ssleay/perl-net-ssleay.mk > @@ -13,4 +13,9 @@ PERL_NET_SSLEAY_LICENSE_FILES = LICENSE > > PERL_NET_SSLEAY_CONF_ENV = OPENSSL_PREFIX=$(STAGING_DIR)/usr > > +define PERL_NET_SSLEAY_FIX_MAKEFILE > + $(SED) 's/^LDDLFLAGS =.*/LDDLFLAGS = -shared/' $(@D)/Makefile > +endef > +PERL_NET_SSLEAY_POST_CONFIGURE_HOOKS += PERL_NET_SSLEAY_FIX_MAKEFILE What about BR2_PREFER_STATIC_LIB=y configurations, as Peter asked in the review of your initial patch? Thanks! Thomas
François, All, On 2014-07-03 18:53 +0200, Francois Perrad spake thusly: > the following error occurs after the previous patch > arm-none-linux-gnueabi-gcc: error: unrecognized command line option '-shared ' > > so, force LDDLFLAGS without quote > > note: previously LDDLFLAGS was correct > Signed-off-by: Francois Perrad <francois.perrad@gadz.org> I've dropped this patch from my resend [0], and marked it Rejected in the patchwork, because I submitted an alternative patch, and C extensions to Perl can not be built static anyway. [0] http://lists.busybox.net/pipermail/buildroot/2014-July/101699.html Regards, Yann E. MORIN. > --- > package/perl-net-ssleay/perl-net-ssleay.mk | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/package/perl-net-ssleay/perl-net-ssleay.mk b/package/perl-net-ssleay/perl-net-ssleay.mk > index 7e4c194..48ff715 100644 > --- a/package/perl-net-ssleay/perl-net-ssleay.mk > +++ b/package/perl-net-ssleay/perl-net-ssleay.mk > @@ -13,4 +13,9 @@ PERL_NET_SSLEAY_LICENSE_FILES = LICENSE > > PERL_NET_SSLEAY_CONF_ENV = OPENSSL_PREFIX=$(STAGING_DIR)/usr > > +define PERL_NET_SSLEAY_FIX_MAKEFILE > + $(SED) 's/^LDDLFLAGS =.*/LDDLFLAGS = -shared/' $(@D)/Makefile > +endef > +PERL_NET_SSLEAY_POST_CONFIGURE_HOOKS += PERL_NET_SSLEAY_FIX_MAKEFILE > + > $(eval $(perl-package)) > -- > 1.9.1 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
2014-07-13 15:35 GMT+02:00 Yann E. MORIN <yann.morin.1998@free.fr>: > François, All, > > On 2014-07-03 18:53 +0200, Francois Perrad spake thusly: >> the following error occurs after the previous patch >> arm-none-linux-gnueabi-gcc: error: unrecognized command line option '-shared ' >> >> so, force LDDLFLAGS without quote >> >> note: previously LDDLFLAGS was correct >> Signed-off-by: Francois Perrad <francois.perrad@gadz.org> > > I've dropped this patch from my resend [0], and marked it Rejected in > the patchwork, because I submitted an alternative patch, and C extensions > to Perl can not be built static anyway. > > [0] http://lists.busybox.net/pipermail/buildroot/2014-July/101699.html > On my box, with all patches already applied in the trunk, I still need this patch. François > Regards, > Yann E. MORIN. > >> --- >> package/perl-net-ssleay/perl-net-ssleay.mk | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/package/perl-net-ssleay/perl-net-ssleay.mk b/package/perl-net-ssleay/perl-net-ssleay.mk >> index 7e4c194..48ff715 100644 >> --- a/package/perl-net-ssleay/perl-net-ssleay.mk >> +++ b/package/perl-net-ssleay/perl-net-ssleay.mk >> @@ -13,4 +13,9 @@ PERL_NET_SSLEAY_LICENSE_FILES = LICENSE >> >> PERL_NET_SSLEAY_CONF_ENV = OPENSSL_PREFIX=$(STAGING_DIR)/usr >> >> +define PERL_NET_SSLEAY_FIX_MAKEFILE >> + $(SED) 's/^LDDLFLAGS =.*/LDDLFLAGS = -shared/' $(@D)/Makefile >> +endef >> +PERL_NET_SSLEAY_POST_CONFIGURE_HOOKS += PERL_NET_SSLEAY_FIX_MAKEFILE >> + >> $(eval $(perl-package)) >> -- >> 1.9.1 >> >> _______________________________________________ >> buildroot mailing list >> buildroot@busybox.net >> http://lists.busybox.net/mailman/listinfo/buildroot > > -- > .-----------------.--------------------.------------------.--------------------. > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | > | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | > '------------------------------^-------^------------------^--------------------' > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
François, All, On 2014-07-14 21:52 +0200, François Perrad spake thusly: > 2014-07-13 15:35 GMT+02:00 Yann E. MORIN <yann.morin.1998@free.fr>: > > On 2014-07-03 18:53 +0200, Francois Perrad spake thusly: > >> the following error occurs after the previous patch > >> arm-none-linux-gnueabi-gcc: error: unrecognized command line option '-shared ' > >> > >> so, force LDDLFLAGS without quote > >> > >> note: previously LDDLFLAGS was correct > >> Signed-off-by: Francois Perrad <francois.perrad@gadz.org> > > > > I've dropped this patch from my resend [0], and marked it Rejected in > > the patchwork, because I submitted an alternative patch, and C extensions > > to Perl can not be built static anyway. > > On my box, with all patches already applied in the trunk, I still need > this patch. Ah, I see. I re-tested here, and indeed, it does perl-net-ssleay does not build anymore. I swear I was able to build it before I removed that patch... :-( However, I have investigated a bit, and here are my findings: - our pkg-perl simply calls 'perl' to run the configure steps - this calls to the host system's perl - it also passes (among many other flags):: --config lddlflags="-shared $$(TARGET_LDFLAGS)" - this gets shoehorned into the generated Makefile as: LDDLFLAGS = '-shared ' - which, when calling gcc for the link step, is then passed as: ...-gcc '-shared ' ... - which is interpreted by gcc as the option '-shared ', so with a trailing space. Removing the -shared from the configure steps yields a Makefile with: LDDLFLAGS = -shared -L/usr/local/lib -fstack-protector Notice how there is no longer any single-quote around the value. And now, it builds! However, there is an unwanted -L/usr/local/lib option, which is properly wrong, since we're doing cross-compilation. So, where does it come from? Well, remember we're calling the host system's perl. On my system, I was able to track the definition of LDDLFALGS to this file: /usr/lib/perl/5.18.2/Config_heavy.pl which aptly contains: lddlflags='-shared -L/usr/local/lib -fstack-protector' Changing the 'local' in there by 'YEM' would yield a Makefile for perl-net-ssleay with, guess what? The following: LDDLFLAGS = -shared -L/usr/YEM/lib -fstack-protector Bingo! But why doesn't it take the value we pass on the configure line? Ah, for my config, $(TARGET_LDFLAGS) is empty. So, it seems that if we pass an empty value to --lddlflags, then it uses the default value specified in the installation's files. That's not good... So, it seems we would need to do one of the following: - find a way to pass a no-op, non-empty value to lddlflags, or - munge all generated Makefile so they no longer have paths to the host system libs/includes, or - tell the host perl not to use system paths, but I guess perl is not well equipped to be gentle to cross-compiletion, or - build our own host-perl and munge its installed files so they point to $(STAGING_DIR) (instead of $(HOST_DIR), probably) Heck, I think the first option is the quickest as a workaround, but that the latest is the safest, although the most complex. I doubt the third would be that easy, while with the second option, we may miss something... :-( In any case, the -shared value in the configure steps is absolutely not needed (and it breaks the build!) I'm testing the other extensions now to see if we can really remove it... BTW, all the above is also valid for LDFLAGS, sicne mine also contain an option -L/usr/local/lib . Regards, Yann E. MORIN.
François, All, On 2014-07-15 00:43 +0200, Yann E. MORIN spake thusly: > On 2014-07-14 21:52 +0200, François Perrad spake thusly: > > 2014-07-13 15:35 GMT+02:00 Yann E. MORIN <yann.morin.1998@free.fr>: > > > On 2014-07-03 18:53 +0200, Francois Perrad spake thusly: > > >> the following error occurs after the previous patch > > >> arm-none-linux-gnueabi-gcc: error: unrecognized command line option '-shared ' > > >> > > >> so, force LDDLFLAGS without quote > > >> > > >> note: previously LDDLFLAGS was correct > > >> Signed-off-by: Francois Perrad <francois.perrad@gadz.org> > > > > > > I've dropped this patch from my resend [0], and marked it Rejected in > > > the patchwork, because I submitted an alternative patch, and C extensions > > > to Perl can not be built static anyway. > > > > On my box, with all patches already applied in the trunk, I still need > > this patch. > > Ah, I see. I re-tested here, and indeed, it does perl-net-ssleay does > not build anymore. > > I swear I was able to build it before I removed that patch... :-( OK, that's probably because I had removed -shared fron pkg-perl.mk and forgot about it. > However, I have investigated a bit, and here are my findings: > > - our pkg-perl simply calls 'perl' to run the configure steps > - this calls to the host system's perl > - it also passes (among many other flags):: > --config lddlflags="-shared $$(TARGET_LDFLAGS)" I tried to set TARGET_LDFLAGS="-g" since -g is simply ignored by ld, and I left the -shared in lddlflags on the configure line, but then, here's what I got: arm-linux-gnueabihf-gcc: error: unrecognized command line option ‘-shared -g’ Bummer! So, if we pass more than one option to --lddlflags, the perl infra completely derails, and sets LDDLFLAGS in the Makefile, to: LDDLFLAGS = '-shared -g' Bad, real bad... :-( OK, let's see what happens to other extensions. What about perl-mojolicious? Here's what LDDLFLAGS looks like with -shared on the configure line, and TARGET_LDFLAGS=-g: LDDLFLAGS = -shared -g Oooookay... And other extensions are OK, too. So, that's not the perl infra that is brain-dead, that's really perl-net-ssleay which is completely f*cked up... :-( OK, I'll revive your patch, with a few quirks... Regards, Yann E. MORIN.
François, All, On 2014-07-15 01:22 +0200, Yann E. MORIN spake thusly: > On 2014-07-15 00:43 +0200, Yann E. MORIN spake thusly: > > On 2014-07-14 21:52 +0200, François Perrad spake thusly: > > > 2014-07-13 15:35 GMT+02:00 Yann E. MORIN <yann.morin.1998@free.fr>: > > > > I've dropped this patch from my resend [0], and marked it Rejected in > > > > the patchwork, because I submitted an alternative patch, and C extensions > > > > to Perl can not be built static anyway. > > > On my box, with all patches already applied in the trunk, I still need > > > this patch. > OK, I'll revive your patch, with a few quirks... And the new patch has been posted, now: http://patchwork.ozlabs.org/patch/369784/ Regards, Yann E. MORIN.
diff --git a/package/perl-net-ssleay/perl-net-ssleay.mk b/package/perl-net-ssleay/perl-net-ssleay.mk index 7e4c194..48ff715 100644 --- a/package/perl-net-ssleay/perl-net-ssleay.mk +++ b/package/perl-net-ssleay/perl-net-ssleay.mk @@ -13,4 +13,9 @@ PERL_NET_SSLEAY_LICENSE_FILES = LICENSE PERL_NET_SSLEAY_CONF_ENV = OPENSSL_PREFIX=$(STAGING_DIR)/usr +define PERL_NET_SSLEAY_FIX_MAKEFILE + $(SED) 's/^LDDLFLAGS =.*/LDDLFLAGS = -shared/' $(@D)/Makefile +endef +PERL_NET_SSLEAY_POST_CONFIGURE_HOOKS += PERL_NET_SSLEAY_FIX_MAKEFILE + $(eval $(perl-package))
the following error occurs after the previous patch arm-none-linux-gnueabi-gcc: error: unrecognized command line option '-shared ' so, force LDDLFLAGS without quote note: previously LDDLFLAGS was correct Signed-off-by: Francois Perrad <francois.perrad@gadz.org> --- package/perl-net-ssleay/perl-net-ssleay.mk | 5 +++++ 1 file changed, 5 insertions(+)