diff mbox

[4/5] python: do not install the IDLE editor

Message ID 1403992343-29665-5-git-send-email-thomas.petazzoni@free-electrons.com
State Accepted
Commit 12b6eebe1295b9f63d5b67fd35efb77fa12dc886
Headers show

Commit Message

Thomas Petazzoni June 28, 2014, 9:52 p.m. UTC 
IDLE is the Python IDE built with the tkinter GUI toolkit, for which
the main script has always been removed from the target (so it was
never usable in Buildroot). However, we were still installing about
800 to 900 KB of .pyc files used only by the idle editor. This commit
adds a Python patch that completely gets rid of the
compilation/installation of the idle editor. As a consequence, it is
no longer needed to manually remove the 'idle' program from the
target in python.mk.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/python/python-114-remove-idle-editor.patch | 43 ++++++++++++++++++++++
 package/python/python.mk                           |  1 -
 2 files changed, 43 insertions(+), 1 deletion(-)
 create mode 100644 package/python/python-114-remove-idle-editor.patch
diff mbox

Patch

diff --git a/package/python/python-114-remove-idle-editor.patch b/package/python/python-114-remove-idle-editor.patch
new file mode 100644
index 0000000..0f73677
--- /dev/null
+++ b/package/python/python-114-remove-idle-editor.patch
@@ -0,0 +1,43 @@ 
+Do not install the idle editor
+
+IDLE is the Python IDE built with the tkinter GUI toolkit. Since it's
+highly unlikely to ever be useful in an embedded Linux system
+generated by Buildroot, this patch simply disables the installation of
+idle and the related Python modules. It saves 800 KB-900 KB of
+installed .pyc files.
+
+Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
+
+Index: b/Makefile.pre.in
+===================================================================
+--- a/Makefile.pre.in
++++ b/Makefile.pre.in
+@@ -934,7 +934,6 @@
+ 		json \
+ 		logging csv importlib wsgiref \
+ 		ctypes ctypes/macholib \
+-		idlelib idlelib/Icons \
+ 		distutils distutils/command \
+ 		multiprocessing multiprocessing/dummy \
+ 		unittest \
+@@ -949,7 +948,6 @@
+ 	email/test email/test/data \
+ 	json/tests \
+ 	ctypes/test \
+-	idlelib/idle_test \
+ 	distutils/tests \
+ 	unittest/test
+ 
+Index: b/setup.py
+===================================================================
+--- a/setup.py
++++ b/setup.py
+@@ -2218,7 +2218,7 @@
+     import warnings
+     warnings.filterwarnings("ignore",category=DeprecationWarning)
+ 
+-    scripts = ['Tools/scripts/idle', 'Lib/smtpd.py']
++    scripts = ['Lib/smtpd.py']
+     if not '--disable-pydoc' in sysconfig.get_config_var("CONFIG_ARGS"):
+         scripts += [ 'Tools/scripts/pydoc' ]
+     if not '--disable-lib2to3' in sysconfig.get_config_var("CONFIG_ARGS"):
diff --git a/package/python/python.mk b/package/python/python.mk
index c005712..532e120 100644
--- a/package/python/python.mk
+++ b/package/python/python.mk
@@ -153,7 +153,6 @@  PYTHON_POST_PATCH_HOOKS += PYTHON_TOUCH_GRAMMAR_FILES
 # idle & smtpd.py have bad shebangs and are mostly samples
 #
 define PYTHON_REMOVE_USELESS_FILES
-	rm -f $(TARGET_DIR)/usr/bin/idle
 	rm -f $(TARGET_DIR)/usr/bin/python$(PYTHON_VERSION_MAJOR)-config
 	rm -f $(TARGET_DIR)/usr/bin/python2-config
 	rm -f $(TARGET_DIR)/usr/bin/python-config